Refactor status util function (#1137)

This commit is contained in:
Shuchang Zheng
2024-11-05 08:02:06 -08:00
committed by GitHub
parent c85a0e9185
commit 4cfc793841
2 changed files with 2 additions and 15 deletions

View File

@@ -1,13 +0,0 @@
import { Status, TaskApiResponse } from "./types";
const finalTaskStates: Array<Status> = [
Status.Canceled,
Status.Completed,
Status.Terminated,
Status.TimedOut,
Status.Failed,
];
export function taskIsFinalized(task: TaskApiResponse) {
return finalTaskStates.includes(task.status);
}

View File

@@ -24,7 +24,6 @@ import { CopyIcon, PlayIcon, ReloadIcon } from "@radix-ui/react-icons";
import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
import { Link, NavLink, Outlet, useParams } from "react-router-dom";
import { useTaskQuery } from "./hooks/useTaskQuery";
import { taskIsFinalized } from "@/api/utils";
import fetchToCurl from "fetch-to-curl";
import { apiBaseUrl } from "@/util/env";
import { useApiCredential } from "@/hooks/useApiCredential";
@@ -32,6 +31,7 @@ import { copyText } from "@/util/copyText";
import { WorkflowApiResponse } from "@/routes/workflows/types/workflowTypes";
import { StatusBadge } from "@/components/StatusBadge";
import { CodeEditor } from "@/routes/workflows/components/CodeEditor";
import { statusIsFinalized } from "../types";
function createTaskRequestObject(values: TaskApiResponse) {
return {
@@ -147,7 +147,7 @@ function TaskDetails() {
const taskIsRunningOrQueued =
task?.status === Status.Running || task?.status === Status.Queued;
const taskHasTerminalState = task && taskIsFinalized(task);
const taskHasTerminalState = task && statusIsFinalized(task);
const showFailureReason =
task?.status === Status.Failed ||