From 4cfc7938415ab831aa2e1860b45871b5cddfa45f Mon Sep 17 00:00:00 2001
From: Shuchang Zheng <wintonzheng0325@gmail.com>
Date: Tue, 5 Nov 2024 08:02:06 -0800
Subject: [PATCH] Refactor status util function (#1137)

---
 skyvern-frontend/src/api/utils.ts                   | 13 -------------
 .../src/routes/tasks/detail/TaskDetails.tsx         |  4 ++--
 2 files changed, 2 insertions(+), 15 deletions(-)
 delete mode 100644 skyvern-frontend/src/api/utils.ts

diff --git a/skyvern-frontend/src/api/utils.ts b/skyvern-frontend/src/api/utils.ts
deleted file mode 100644
index dfa9fe53..00000000
--- a/skyvern-frontend/src/api/utils.ts
+++ /dev/null
@@ -1,13 +0,0 @@
-import { Status, TaskApiResponse } from "./types";
-
-const finalTaskStates: Array<Status> = [
-  Status.Canceled,
-  Status.Completed,
-  Status.Terminated,
-  Status.TimedOut,
-  Status.Failed,
-];
-
-export function taskIsFinalized(task: TaskApiResponse) {
-  return finalTaskStates.includes(task.status);
-}
diff --git a/skyvern-frontend/src/routes/tasks/detail/TaskDetails.tsx b/skyvern-frontend/src/routes/tasks/detail/TaskDetails.tsx
index c00c03b0..8541c86f 100644
--- a/skyvern-frontend/src/routes/tasks/detail/TaskDetails.tsx
+++ b/skyvern-frontend/src/routes/tasks/detail/TaskDetails.tsx
@@ -24,7 +24,6 @@ import { CopyIcon, PlayIcon, ReloadIcon } from "@radix-ui/react-icons";
 import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
 import { Link, NavLink, Outlet, useParams } from "react-router-dom";
 import { useTaskQuery } from "./hooks/useTaskQuery";
-import { taskIsFinalized } from "@/api/utils";
 import fetchToCurl from "fetch-to-curl";
 import { apiBaseUrl } from "@/util/env";
 import { useApiCredential } from "@/hooks/useApiCredential";
@@ -32,6 +31,7 @@ import { copyText } from "@/util/copyText";
 import { WorkflowApiResponse } from "@/routes/workflows/types/workflowTypes";
 import { StatusBadge } from "@/components/StatusBadge";
 import { CodeEditor } from "@/routes/workflows/components/CodeEditor";
+import { statusIsFinalized } from "../types";
 
 function createTaskRequestObject(values: TaskApiResponse) {
   return {
@@ -147,7 +147,7 @@ function TaskDetails() {
   const taskIsRunningOrQueued =
     task?.status === Status.Running || task?.status === Status.Queued;
 
-  const taskHasTerminalState = task && taskIsFinalized(task);
+  const taskHasTerminalState = task && statusIsFinalized(task);
 
   const showFailureReason =
     task?.status === Status.Failed ||