vodorod/Dorod-Sky
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Add a max height for task form code editor fields (#941)

Browse Source
This commit is contained in:
Kerem Yilmaz
2024-10-09 08:01:24 -07:00
committed by GitHub
parent 0b9afe8b59
commit f6cbffe190
3 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx
View File

@@ -295,6 +295,7 @@ function CreateNewTaskForm({ initialValues }: Props) {
language="json"
fontSize={12}
minHeight="96px"
maxHeight="500px"
value={
field.value === null ? "" : field.value
}
@@ -389,6 +390,7 @@ function CreateNewTaskForm({ initialValues }: Props) {
language="json"
fontSize={12}
minHeight="96px"
maxHeight="500px"
value={field.value === null ? "" : field.value}
/>
</FormControl>
@@ -509,6 +511,7 @@ function CreateNewTaskForm({ initialValues }: Props) {
language="json"
fontSize={12}
minHeight="96px"
maxHeight="500px"
value={field.value === null ? "" : field.value}
/>
</FormControl>

3
skyvern-frontend/src/routes/tasks/create/SavedTaskForm.tsx
View File

@@ -464,6 +464,7 @@ function SavedTaskForm({ initialValues }: Props) {
language="json"
fontSize={12}
minHeight="96px"
maxHeight="500px"
value={
field.value === null ? "" : field.value
}
@@ -558,6 +559,7 @@ function SavedTaskForm({ initialValues }: Props) {
language="json"
fontSize={14}
minHeight="96px"
maxHeight="500px"
value={
field.value === null ||
typeof field.value === "undefined"
@@ -683,6 +685,7 @@ function SavedTaskForm({ initialValues }: Props) {
language="json"
fontSize={12}
minHeight="96px"
maxHeight="500px"
value={field.value === null ? "" : field.value}
/>
</FormControl>

3
skyvern-frontend/src/routes/workflows/components/CodeEditor.tsx
View File

@@ -10,6 +10,7 @@ type Props = {
language: "python" | "json";
disabled?: boolean;
minHeight?: string;
maxHeight?: string;
className?: string;
fontSize?: number;
};
@@ -18,6 +19,7 @@ function CodeEditor({
value,
onChange,
minHeight,
maxHeight,
language,
className,
fontSize = 8,
@@ -33,6 +35,7 @@ function CodeEditor({
extensions={extensions}
theme={tokyoNightStorm}
minHeight={minHeight}
maxHeight={maxHeight}
className={cn("cursor-auto", className)}
style={{
fontSize: fontSize,