vodorod/Dorod-Sky
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Make collection id required (#1036)

Browse Source
This commit is contained in:
Shuchang Zheng
2024-10-23 14:00:04 -07:00
committed by GitHub
parent 2798c4cc79
commit d6c16180ee
2 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterAddPanel.tsx
View File

@@ -205,7 +205,7 @@ function WorkflowParameterAddPanel({ type, onClose, onSave }: Props) {
} catch (e) {
toast({
variant: "destructive",
title: "Failed to save parameters",
title: "Failed to add parameter",
description: "Invalid JSON for default value",
});
return;
@@ -227,6 +227,14 @@ function WorkflowParameterAddPanel({ type, onClose, onSave }: Props) {
});
}
if (type === "credential") {
if (!collectionId) {
toast({
variant: "destructive",
title: "Failed to add parameter",
description: "Collection ID is required",
});
return;
}
onSave({
key,
parameterType: "credential",
@@ -239,7 +247,7 @@ function WorkflowParameterAddPanel({ type, onClose, onSave }: Props) {
if (!sourceParameterKey) {
toast({
variant: "destructive",
title: "Failed to save parameters",
title: "Failed to add parameter",
description: "Source parameter key is required",
});
return;

12
skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterEditPanel.tsx
View File

@@ -238,7 +238,7 @@ function WorkflowParameterEditPanel({
} catch (e) {
toast({
variant: "destructive",
title: "Failed to save parameters",
title: "Failed to save parameter",
description: "Invalid JSON for default value",
});
return;
@@ -260,6 +260,14 @@ function WorkflowParameterEditPanel({
});
}
if (type === "credential") {
if (!collectionId) {
toast({
variant: "destructive",
title: "Failed to save parameter",
description: "Collection ID is required",
});
return;
}
onSave({
key,
parameterType: "credential",
@@ -272,7 +280,7 @@ function WorkflowParameterEditPanel({
if (!sourceParameterKey) {
toast({
variant: "destructive",
title: "Failed to save parameters",
title: "Failed to save parameter",
description: "Source parameter key is required",
});
return;