vodorod/Dorod-Sky
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

add helper check_downloading_files_and_wait_for_download_to_complete to action handler (#4475)

Browse Source
This commit is contained in:
Shuchang Zheng
2026-01-16 16:27:31 -08:00
committed by GitHub
parent 089fafcf8d
commit d537e9dc5a
2 changed files with 41 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
skyvern/forge/sdk/api/files.py
View File

@@ -339,6 +339,39 @@ async def wait_for_download_finished(downloading_files: list[str], timeout: floa
raise DownloadFileMaxWaitingTime(downloading_files=cur_downloading_files)
async def check_downloading_files_and_wait_for_download_to_complete(
download_dir: Path,
organization_id: str,
browser_session_id: str | None = None,
timeout: float = BROWSER_DOWNLOAD_TIMEOUT,
) -> None:
# check if there's any file is still downloading
downloading_files = list_downloading_files_in_directory(download_dir)
if browser_session_id:
files_in_browser_session = await app.STORAGE.list_downloading_files_in_browser_session(
organization_id=organization_id, browser_session_id=browser_session_id
)
downloading_files = downloading_files + files_in_browser_session
if len(downloading_files) == 0:
return
LOG.info(
"File downloading hasn't completed, wait for a while",
downloading_files=downloading_files,
)
try:
await wait_for_download_finished(
downloading_files=downloading_files,
timeout=timeout,
)
except DownloadFileMaxWaitingTime as e:
LOG.warning(
"There're several long-time downloading files, these files might be broken",
downloading_files=e.downloading_files,
)
def get_number_of_files_in_directory(directory: Path, recursive: bool = False) -> int:
return len(list_files_in_directory(directory, recursive))

36
skyvern/webeye/actions/handler.py
View File

@@ -27,7 +27,6 @@ from skyvern.constants import (
from skyvern.errors.errors import TOTPExpiredError
from skyvern.exceptions import (
DownloadedFileNotFound,
DownloadFileMaxWaitingTime,
EmptySelect,
ErrEmptyTweakValue,
ErrFoundSelectableElement,
@@ -62,12 +61,13 @@ from skyvern.exceptions import (
from skyvern.experimentation.wait_utils import get_or_create_wait_config, get_wait_time
from skyvern.forge import app
from skyvern.forge.prompts import prompt_engine
from skyvern.forge.sdk.api.files import (
check_downloading_files_and_wait_for_download_to_complete,
)
from skyvern.forge.sdk.api.files import download_file as download_file_api
from skyvern.forge.sdk.api.files import (
get_download_dir,
list_downloading_files_in_directory,
list_files_in_directory,
wait_for_download_finished,
)
from skyvern.forge.sdk.api.llm.api_handler_factory import LLMAPIHandlerFactory, LLMCallerManager
from skyvern.forge.sdk.api.llm.exceptions import LLMProviderError
@@ -484,32 +484,12 @@ class ActionHandler:
return results
results[-1].download_triggered = True
# check if there's any file is still downloading
downloading_files = list_downloading_files_in_directory(download_dir)
if task.browser_session_id:
files_in_browser_session = await app.STORAGE.list_downloading_files_in_browser_session(
organization_id=task.organization_id, browser_session_id=task.browser_session_id
)
downloading_files = downloading_files + files_in_browser_session
if len(downloading_files) == 0:
return results
LOG.info(
"File downloading hasn't completed, wait for a while",
downloading_files=downloading_files,
workflow_run_id=task.workflow_run_id,
await check_downloading_files_and_wait_for_download_to_complete(
download_dir=download_dir,
organization_id=task.organization_id,
browser_session_id=task.browser_session_id,
timeout=task.download_timeout or BROWSER_DOWNLOAD_TIMEOUT,
)
try:
await wait_for_download_finished(
downloading_files=downloading_files, timeout=task.download_timeout or BROWSER_DOWNLOAD_TIMEOUT
)
except DownloadFileMaxWaitingTime as e:
LOG.warning(
"There're several long-time downloading files, these files might be broken",
downloading_files=e.downloading_files,
workflow_run_id=task.workflow_run_id,
)
return results
finally:
if browser_state is not None and download_triggered: