From fc2e3dc1c18fc2e11b72ae2c4ae7fa5065d6289d Mon Sep 17 00:00:00 2001
From: amhsirak <karishmashuklaa@gmail.com>
Date: Sat, 23 Nov 2024 07:04:18 +0530
Subject: [PATCH] feat: join base url with href

---
 maxun-core/src/browserSide/scraper.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/maxun-core/src/browserSide/scraper.js b/maxun-core/src/browserSide/scraper.js
index 79893568..7ee64dc1 100644
--- a/maxun-core/src/browserSide/scraper.js
+++ b/maxun-core/src/browserSide/scraper.js
@@ -235,7 +235,8 @@ function scrapableHeuristics(maxCountPerPage = 50, minArea = 20000, scrolls = 3,
 
         switch (attribute) {
           case 'href':
-            return elem.getAttribute('href');
+            const relativeHref = elem.getAttribute('href'); // Get the href attribute
+            return relativeHref ? new URL(relativeHref, window.location.origin).href : null; // Convert to full URL
           case 'src':
             return elem.getAttribute('src');
           case 'innerText':