From 5d9071641346ab060b52e07385535b473c9e6766 Mon Sep 17 00:00:00 2001
From: karishmas6 <carishmashukla28@gmail.com>
Date: Thu, 10 Oct 2024 03:48:10 +0530
Subject: [PATCH 1/4] feat: use id

---
 src/api/storage.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/api/storage.ts b/src/api/storage.ts
index 054aeee8..2ff1e82a 100644
--- a/src/api/storage.ts
+++ b/src/api/storage.ts
@@ -60,13 +60,13 @@ export const deleteRunFromStorage = async (id: string): Promise<boolean> => {
   }
 };
 
-export const editRecordingFromStorage = async (browserId: string, robotId: string): Promise<WorkflowFile | null> => {
+export const editRecordingFromStorage = async (browserId: string, id: string): Promise<WorkflowFile | null> => {
   try {
-    const response = await axios.put(`http://localhost:8080/workflow/${browserId}/${robotId}`);
+    const response = await axios.put(`http://localhost:8080/workflow/${browserId}/${id}`);
     if (response.status === 200) {
       return response.data;
     } else {
-      throw new Error(`Couldn't edit stored recording ${robotId}`);
+      throw new Error(`Couldn't edit stored recording ${id}`);
     }
   } catch(error: any) {
     console.log(error);

From 7ee12216dbd5b2d2cb2c502541247bbd76dfd490 Mon Sep 17 00:00:00 2001
From: karishmas6 <carishmashukla28@gmail.com>
Date: Thu, 10 Oct 2024 04:29:24 +0530
Subject: [PATCH 2/4] feat: set recordingId

---
 src/pages/MainPage.tsx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/pages/MainPage.tsx b/src/pages/MainPage.tsx
index adb0a1f3..34d6811d 100644
--- a/src/pages/MainPage.tsx
+++ b/src/pages/MainPage.tsx
@@ -42,7 +42,7 @@ export const MainPage = ({ handleEditRecording }: MainPageProps) => {
 
   let aborted = false;
 
-  const { notify, setRerenderRuns } = useGlobalInfoStore();
+  const { notify, setRerenderRuns, setRecordingId } = useGlobalInfoStore();
 
   const abortRunHandler = (runId: string) => {
     aborted = true;
@@ -58,6 +58,7 @@ export const MainPage = ({ handleEditRecording }: MainPageProps) => {
 
   const setRecordingInfo = (id: string, name: string) => {
     setRunningRecordingId(id);
+    setRecordingId(id);
     setRunningRecordingName(name);
   }
 

From ee8a16f5ab5ca519ac97bc0354b57589aab7921b Mon Sep 17 00:00:00 2001
From: karishmas6 <carishmashukla28@gmail.com>
Date: Thu, 10 Oct 2024 04:30:03 +0530
Subject: [PATCH 3/4] feat: use recordingId instead of recordingName

---
 src/pages/RecordingPage.tsx | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/pages/RecordingPage.tsx b/src/pages/RecordingPage.tsx
index 8683e691..1d08b931 100644
--- a/src/pages/RecordingPage.tsx
+++ b/src/pages/RecordingPage.tsx
@@ -39,7 +39,7 @@ export const RecordingPage = ({ recordingName }: RecordingPageProps) => {
 
   const { setId, socket } = useSocketStore();
   const { setWidth } = useBrowserDimensionsStore();
-  const { browserId, setBrowserId } = useGlobalInfoStore();
+  const { browserId, setBrowserId, recordingId } = useGlobalInfoStore();
 
   const handleShowOutputData = useCallback(() => {
     setShowOutputData(true);
@@ -93,15 +93,15 @@ export const RecordingPage = ({ recordingName }: RecordingPageProps) => {
   }, [socket]);
 
   const handleLoaded = useCallback(() => {
-    if (recordingName && browserId) {
-      editRecordingFromStorage(browserId, recordingName).then(() => setIsLoaded(true));
+    if (recordingName && browserId && recordingId) {
+      editRecordingFromStorage(browserId, recordingId).then(() => setIsLoaded(true));
     } else {
       if (browserId === 'new-recording') {
         socket?.emit('new-recording');
       }
       setIsLoaded(true);
     }
-  }, [socket, browserId, recordingName, isLoaded])
+  }, [socket, browserId, recordingName,  isLoaded])
 
   useEffect(() => {
     socket?.on('loaded', handleLoaded);

From 29c1675d77ea5550c7cb1a6bdc18075bea493ba8 Mon Sep 17 00:00:00 2001
From: karishmas6 <carishmashukla28@gmail.com>
Date: Thu, 10 Oct 2024 04:30:41 +0530
Subject: [PATCH 4/4] feat: pass recordingId in dependency array

---
 src/pages/RecordingPage.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/pages/RecordingPage.tsx b/src/pages/RecordingPage.tsx
index 1d08b931..19d94c20 100644
--- a/src/pages/RecordingPage.tsx
+++ b/src/pages/RecordingPage.tsx
@@ -101,7 +101,7 @@ export const RecordingPage = ({ recordingName }: RecordingPageProps) => {
       }
       setIsLoaded(true);
     }
-  }, [socket, browserId, recordingName,  isLoaded])
+  }, [socket, browserId, recordingName, recordingId, isLoaded])
 
   useEffect(() => {
     socket?.on('loaded', handleLoaded);