From 0137780e2c2a06a41166e1f7a1b0f0f1cc1fd9a5 Mon Sep 17 00:00:00 2001 From: karishmas6 Date: Sat, 21 Sep 2024 18:49:09 +0530 Subject: [PATCH 1/4] feat: !specify screenshot options --- server/src/browser-management/classes/RemoteBrowser.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/server/src/browser-management/classes/RemoteBrowser.ts b/server/src/browser-management/classes/RemoteBrowser.ts index 04facda6..20ed6925 100644 --- a/server/src/browser-management/classes/RemoteBrowser.ts +++ b/server/src/browser-management/classes/RemoteBrowser.ts @@ -187,9 +187,7 @@ export class RemoteBrowser { */ public makeAndEmitScreenshot = async (): Promise => { try { - const screenshot = await this.currentPage?.screenshot( - { type: 'jpeg', quality: 90, fullPage: true } - ); + const screenshot = await this.currentPage?.screenshot(); if (screenshot) { this.emitScreenshot(screenshot.toString('base64')); } From 42a34634c9726e4a3484ca7698d76e4818200a3b Mon Sep 17 00:00:00 2001 From: karishmas6 Date: Sat, 21 Sep 2024 18:49:29 +0530 Subject: [PATCH 2/4] feat: set quality to 5 --- server/src/browser-management/classes/RemoteBrowser.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/browser-management/classes/RemoteBrowser.ts b/server/src/browser-management/classes/RemoteBrowser.ts index 20ed6925..e38fe1c7 100644 --- a/server/src/browser-management/classes/RemoteBrowser.ts +++ b/server/src/browser-management/classes/RemoteBrowser.ts @@ -320,7 +320,7 @@ export class RemoteBrowser { logger.log('warn', 'client is not initialized'); return; } - await this.client.send('Page.startScreencast', { format: 'jpeg', quality: 90 }); + await this.client.send('Page.startScreencast', { format: 'jpeg', quality: 75 }); logger.log('info', `Browser started with screencasting a page.`); }; From 9d0c7341c4e71ccd797712181e0f1b48628a30af Mon Sep 17 00:00:00 2001 From: karishmas6 Date: Sat, 21 Sep 2024 18:51:11 +0530 Subject: [PATCH 3/4] chore: remove unused imports --- server/src/browser-management/classes/RemoteBrowser.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/browser-management/classes/RemoteBrowser.ts b/server/src/browser-management/classes/RemoteBrowser.ts index e38fe1c7..b93ddb91 100644 --- a/server/src/browser-management/classes/RemoteBrowser.ts +++ b/server/src/browser-management/classes/RemoteBrowser.ts @@ -5,7 +5,7 @@ import { BrowserContext, } from 'playwright'; import { Socket } from "socket.io"; -import { fullLists, PlaywrightBlocker, Request } from '@cliqz/adblocker-playwright'; +import { PlaywrightBlocker } from '@cliqz/adblocker-playwright'; import fetch from 'cross-fetch'; import logger from '../../logger'; From 60458b57919fb5f9cf2968e3ba7b4d0cae02c233 Mon Sep 17 00:00:00 2001 From: karishmas6 Date: Sat, 21 Sep 2024 18:51:53 +0530 Subject: [PATCH 4/4] chore: remove comment --- server/src/browser-management/classes/RemoteBrowser.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/server/src/browser-management/classes/RemoteBrowser.ts b/server/src/browser-management/classes/RemoteBrowser.ts index b93ddb91..70677ed4 100644 --- a/server/src/browser-management/classes/RemoteBrowser.ts +++ b/server/src/browser-management/classes/RemoteBrowser.ts @@ -124,7 +124,6 @@ export class RemoteBrowser { await this.changeTab(tabInfo.index - 1); } } - // close the page and log it await page.close(); logger.log( 'debug',