vodorod/parcer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: child highlighting positioning

Browse Source
This commit is contained in:
Rohit
2025-07-17 23:34:47 +05:30
parent 9fd33539ce
commit 970e145dc3
1 changed files with 17 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
src/helpers/clientSelectorGenerator.ts
View File

@@ -3109,34 +3109,28 @@ class ClientSelectorGenerator {
targetElement: HTMLElement, targetElement: HTMLElement,
rootElement: HTMLElement rootElement: HTMLElement
): string | null { ): string | null {
if ( if (!this.elementContains(rootElement, targetElement) || targetElement === rootElement) {
!this.elementContains(rootElement, targetElement) ||
targetElement === rootElement
) {
return null; return null;
} }
// First, check if target element has conflicting classes
const classes = Array.from(targetElement.classList);
const hasConflictingElement =
classes.length > 0 && rootElement
? this.queryElementsInScope(
rootElement,
targetElement.tagName.toLowerCase()
)
.filter((el) => el !== targetElement)
.some((el) =>
classes.every((cls) =>
(el as HTMLElement).classList.contains(cls)
)
)
: false;
const pathParts: string[] = []; const pathParts: string[] = [];
let current: HTMLElement | null = targetElement; let current: HTMLElement | null = targetElement;
// Build path from target up to root // Build path from target up to root
while (current && current !== rootElement) { while (current && current !== rootElement) {
// Calculate conflicts for each element in the path
const classes = Array.from(current.classList);
const hasConflictingElement =
classes.length > 0 && rootElement
? this.queryElementsInScope(rootElement, current.tagName.toLowerCase())
.filter((el) => el !== current)
.some((el) =>
classes.every((cls) =>
(el as HTMLElement).classList.contains(cls)
)
)
: false;
const pathPart = this.generateOptimizedStructuralStep( const pathPart = this.generateOptimizedStructuralStep(
current, current,
rootElement, rootElement,
@@ -3147,8 +3141,7 @@ class ClientSelectorGenerator {
} }
// Move to parent (either regular parent or shadow host) // Move to parent (either regular parent or shadow host)
current = current = current.parentElement ||
current.parentElement ||
((current.getRootNode() as ShadowRoot).host as HTMLElement | null); ((current.getRootNode() as ShadowRoot).host as HTMLElement | null);
if (!current) break; if (!current) break;
@@ -3158,10 +3151,7 @@ class ClientSelectorGenerator {
} }
// Helper method to check containment (works for both light and shadow DOM) // Helper method to check containment (works for both light and shadow DOM)
private elementContains( private elementContains(container: HTMLElement, element: HTMLElement): boolean {
container: HTMLElement,
element: HTMLElement
): boolean {
// Standard containment check // Standard containment check
if (container.contains(element)) { if (container.contains(element)) {
return true; return true;
@@ -3175,8 +3165,7 @@ class ClientSelectorGenerator {
} }
// Move to parent or shadow host // Move to parent or shadow host
current = current = current.parentElement ||
current.parentElement ||
((current.getRootNode() as ShadowRoot).host as HTMLElement | null); ((current.getRootNode() as ShadowRoot).host as HTMLElement | null);
} }