From 8d0fadfa1115752d619def9b45127fb5fa83a806 Mon Sep 17 00:00:00 2001
From: karishmas6 <carishmashukla28@gmail.com>
Date: Thu, 10 Oct 2024 20:15:48 +0530
Subject: [PATCH] feat: disable confirm capture if unconfirmed fields

---
 src/components/organisms/RightSidePanel.tsx | 35 +++++++++++----------
 1 file changed, 18 insertions(+), 17 deletions(-)

diff --git a/src/components/organisms/RightSidePanel.tsx b/src/components/organisms/RightSidePanel.tsx
index 949a15ad..aa2b319a 100644
--- a/src/components/organisms/RightSidePanel.tsx
+++ b/src/components/organisms/RightSidePanel.tsx
@@ -271,15 +271,11 @@ export const RightSidePanel: React.FC<RightSidePanelProps> = ({ onFinishCapture
     onFinishCapture();
   }, [stopGetList, getListSettingsObject, socket, notify, handleStopGetList]);
 
+  const hasUnconfirmedListTextFields = browserSteps.some(step => step.type === 'list' && Object.values(step.fields).some(field => !confirmedListTextFields[step.id]?.[field.id]));
+
   const handleConfirmListCapture = useCallback(() => {
     switch (captureStage) {
       case 'initial':
-        const hasUnconfirmedListTextFields = browserSteps.some(step => step.type === 'list' && Object.values(step.fields).some(field => !confirmedListTextFields[step.id]?.[field.id]));
-        if (hasUnconfirmedListTextFields) {
-          notify('error', 'Please confirm all field labels.');
-          return;
-        }
-        startPaginationMode();
         setShowPaginationOptions(true);
         setCaptureStage('pagination');
         break;
@@ -376,17 +372,22 @@ export const RightSidePanel: React.FC<RightSidePanelProps> = ({ onFinishCapture
       <Box display="flex" flexDirection="column" gap={2} style={{ margin: '15px' }}>
         {!getText && !getScreenshot && !getList && showCaptureList && <Button variant="contained" onClick={startGetList}>Capture List</Button>}
         {getList && (
-          <>
-            <Box display="flex" justifyContent="space-between" gap={2} style={{ margin: '15px' }}>
-              <Button variant="outlined" onClick={handleConfirmListCapture}>
-                {captureStage === 'initial' ? 'Confirm Capture' :
-                  captureStage === 'pagination' ? 'Confirm Pagination' :
-                    captureStage === 'limit' ? 'Confirm Limit' : 'Finish Capture'}
-              </Button>
-              <Button variant="outlined" color="error" onClick={discardGetList}>Discard</Button>
-            </Box>
-          </>
-        )}
+  <>
+    <Box display="flex" justifyContent="space-between" gap={2} style={{ margin: '15px' }}>
+      <Button
+        variant="outlined"
+        onClick={handleConfirmListCapture}
+        disabled={hasUnconfirmedListTextFields}
+      >
+        {captureStage === 'initial' ? 'Confirm Capture' :
+          captureStage === 'pagination' ? 'Confirm Pagination' :
+            captureStage === 'limit' ? 'Confirm Limit' : 'Finish Capture'}
+      </Button>
+      <Button variant="outlined" color="error" onClick={discardGetList}>Discard</Button>
+    </Box>
+  </>
+)}
+
         {showPaginationOptions && (
           <Box display="flex" flexDirection="column" gap={2} style={{ margin: '15px' }}>
             <Typography>How can we find the next list item on the page?</Typography>