From 744e8df55866829d630b78c3d4b614978e379376 Mon Sep 17 00:00:00 2001 From: karishmas6 Date: Sun, 27 Oct 2024 18:05:08 +0530 Subject: [PATCH] fix: apply proxy config only if proxy server available --- .../classes/RemoteBrowser.ts | 25 +++++++++++-------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/server/src/browser-management/classes/RemoteBrowser.ts b/server/src/browser-management/classes/RemoteBrowser.ts index 83dd75f0..945fd21e 100644 --- a/server/src/browser-management/classes/RemoteBrowser.ts +++ b/server/src/browser-management/classes/RemoteBrowser.ts @@ -104,17 +104,20 @@ export class RemoteBrowser { }), }; } - this.context = await this.browser.newContext( - { - viewport: { height: 400, width: 900 }, - // recordVideo: { dir: 'videos/' } - proxy: { - server: proxyOptions.server, - username: proxyOptions.username ? proxyOptions.username : undefined, - password: proxyOptions.password ? proxyOptions.password : undefined, - } - } - ); + const contextOptions: any = { + viewport: { height: 400, width: 900 }, + // recordVideo: { dir: 'videos/' } + }; + + if (proxyOptions.server) { + contextOptions.proxy = { + server: proxyOptions.server, + username: proxyOptions.username ? proxyOptions.username : undefined, + password: proxyOptions.password ? proxyOptions.password : undefined, + }; + } + + this.context = await this.browser.newContext(contextOptions); this.currentPage = await this.context.newPage(); const blocker = await PlaywrightBlocker.fromPrebuiltAdsAndTracking(fetch); await blocker.enableBlockingInPage(this.currentPage);