From be55f8ee6573225d08942dde2173df2e4f66f68f Mon Sep 17 00:00:00 2001 From: karishmas6 Date: Fri, 29 Nov 2024 22:07:26 +0530 Subject: [PATCH 1/9] feat: log robot run error --- server/src/api/record.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/api/record.ts b/server/src/api/record.ts index fef0be9a..b9d78a41 100644 --- a/server/src/api/record.ts +++ b/server/src/api/record.ts @@ -621,7 +621,7 @@ async function executeRun(id: string) { }; } catch (error: any) { - logger.log('info', `Error while running a recording with id: ${id} - ${error.message}`); + logger.log('info', `Error while running a robot with id: ${id} - ${error.message}`); const run = await Run.findOne({ where: { runId: id } }); if (run) { await run.update({ From 8cce8f41de437fad5a319d8e80cde28a8ed4a044 Mon Sep 17 00:00:00 2001 From: karishmas6 Date: Fri, 29 Nov 2024 22:07:51 +0530 Subject: [PATCH 2/9] feat: log robot run --- server/src/api/record.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/api/record.ts b/server/src/api/record.ts index b9d78a41..c377caa5 100644 --- a/server/src/api/record.ts +++ b/server/src/api/record.ts @@ -660,7 +660,7 @@ export async function handleRunRecording(id: string, userId: string) { socket.on('ready-for-run', () => readyForRunHandler(browserId, newRunId)); - logger.log('info', `Running recording: ${id}`); + logger.log('info', `Running Robot: ${id}`); socket.on('disconnect', () => { cleanupSocketListeners(socket, browserId, newRunId); From 14d9679324f71aa4452af0772391f9d98b72b808 Mon Sep 17 00:00:00 2001 From: karishmas6 Date: Fri, 29 Nov 2024 22:08:03 +0530 Subject: [PATCH 3/9] feat: log robot run error --- server/src/api/record.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/api/record.ts b/server/src/api/record.ts index c377caa5..5b33b12f 100644 --- a/server/src/api/record.ts +++ b/server/src/api/record.ts @@ -670,7 +670,7 @@ export async function handleRunRecording(id: string, userId: string) { return newRunId; } catch (error: any) { - logger.error('Error running recording:', error); + logger.error('Error running robot:', error); } } From 0c4f860b14b5490e4decebd0b05ed9fe293853c6 Mon Sep 17 00:00:00 2001 From: karishmas6 Date: Fri, 29 Nov 2024 22:10:10 +0530 Subject: [PATCH 4/9] feat: log screencast error --- server/src/browser-management/classes/RemoteBrowser.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/browser-management/classes/RemoteBrowser.ts b/server/src/browser-management/classes/RemoteBrowser.ts index 07ea8780..30541dd7 100644 --- a/server/src/browser-management/classes/RemoteBrowser.ts +++ b/server/src/browser-management/classes/RemoteBrowser.ts @@ -244,7 +244,7 @@ export class RemoteBrowser { } await this.client.send('Page.screencastFrameAck', { sessionId: sessionId }); } catch (e) { - logger.log('error', e); + logger.log('error', `Screencast error: ${e.message}`); } }, 100); }); From d503dc3fccda961794ec77a0b074b02c7a05fdee Mon Sep 17 00:00:00 2001 From: karishmas6 Date: Fri, 29 Nov 2024 22:10:48 +0530 Subject: [PATCH 5/9] feat(ts): set type as any --- server/src/browser-management/classes/RemoteBrowser.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/src/browser-management/classes/RemoteBrowser.ts b/server/src/browser-management/classes/RemoteBrowser.ts index 30541dd7..5455a05d 100644 --- a/server/src/browser-management/classes/RemoteBrowser.ts +++ b/server/src/browser-management/classes/RemoteBrowser.ts @@ -243,8 +243,8 @@ export class RemoteBrowser { return; } await this.client.send('Page.screencastFrameAck', { sessionId: sessionId }); - } catch (e) { - logger.log('error', `Screencast error: ${e.message}`); + } catch (e: any) { + logger.log('error', `Screencast error: ${e}`); } }, 100); }); From 9ac4677999eea6bfda7247bcd624f3e7f8b34928 Mon Sep 17 00:00:00 2001 From: karishmas6 Date: Fri, 29 Nov 2024 22:11:16 +0530 Subject: [PATCH 6/9] feat: log screenshot error --- server/src/browser-management/classes/RemoteBrowser.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/browser-management/classes/RemoteBrowser.ts b/server/src/browser-management/classes/RemoteBrowser.ts index 5455a05d..eb4051c6 100644 --- a/server/src/browser-management/classes/RemoteBrowser.ts +++ b/server/src/browser-management/classes/RemoteBrowser.ts @@ -278,7 +278,7 @@ export class RemoteBrowser { } } catch (e) { const { message } = e as Error; - logger.log('error', message); + logger.log('error', `Screenshot error: ${message}`); } }; From 4521708db87d56deee8eac9cd56a3cb04af8366b Mon Sep 17 00:00:00 2001 From: karishmas6 Date: Fri, 29 Nov 2024 22:12:16 +0530 Subject: [PATCH 7/9] feat: log robot read error --- server/src/routes/storage.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/src/routes/storage.ts b/server/src/routes/storage.ts index f84583d0..9151e533 100644 --- a/server/src/routes/storage.ts +++ b/server/src/routes/storage.ts @@ -38,7 +38,7 @@ router.get('/recordings', requireSignIn, async (req, res) => { const data = await Robot.findAll(); return res.send(data); } catch (e) { - logger.log('info', 'Error while reading recordings'); + logger.log('info', 'Error while reading robots'); return res.send(null); } }); @@ -55,7 +55,7 @@ router.get('/recordings/:id', requireSignIn, async (req, res) => { ); return res.send(data); } catch (e) { - logger.log('info', 'Error while reading recordings'); + logger.log('info', 'Error while reading robots'); return res.send(null); } }) From 5ff6dcddc1c58b3826845258bd1b9d6d88197c96 Mon Sep 17 00:00:00 2001 From: karishmas6 Date: Fri, 29 Nov 2024 22:13:03 +0530 Subject: [PATCH 8/9] feat: log robot run error --- server/src/routes/storage.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/src/routes/storage.ts b/server/src/routes/storage.ts index 9151e533..d1f648f8 100644 --- a/server/src/routes/storage.ts +++ b/server/src/routes/storage.ts @@ -400,7 +400,7 @@ router.put('/runs/:id', requireSignIn, async (req: AuthenticatedRequest, res) => }); } catch (e) { const { message } = e as Error; - logger.log('info', `Error while creating a run with recording id: ${req.params.id} - ${message}`); + logger.log('info', `Error while creating a run with robot id: ${req.params.id} - ${message}`); return res.send(''); } }); @@ -518,7 +518,7 @@ router.post('/runs/run/:id', requireSignIn, async (req: AuthenticatedRequest, re finishedAt: new Date().toLocaleString(), }); } - logger.log('info', `Error while running a recording with id: ${req.params.id} - ${message}`); + logger.log('info', `Error while running a robot with id: ${req.params.id} - ${message}`); capture( 'maxun-oss-run-created-manual', { @@ -757,7 +757,7 @@ router.post('/runs/abort/:id', requireSignIn, async (req, res) => { return res.send(true); } catch (e) { const { message } = e as Error; - logger.log('info', `Error while running a recording with name: ${req.params.fileName}_${req.params.runId}.json`); + logger.log('info', `Error while running a robot with name: ${req.params.fileName}_${req.params.runId}.json`); return res.send(false); } }); \ No newline at end of file From 3f5c30bae9344b07d368ab6fba7ceb51ef512d06 Mon Sep 17 00:00:00 2001 From: karishmas6 Date: Fri, 29 Nov 2024 22:13:45 +0530 Subject: [PATCH 9/9] feat: log robot scheduled run error --- server/src/workflow-management/scheduler/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/src/workflow-management/scheduler/index.ts b/server/src/workflow-management/scheduler/index.ts index 082fcf2e..02ca905f 100644 --- a/server/src/workflow-management/scheduler/index.ts +++ b/server/src/workflow-management/scheduler/index.ts @@ -171,7 +171,7 @@ async function executeRun(id: string) { processGoogleSheetUpdates(); return true; } catch (error: any) { - logger.log('info', `Error while running a recording with id: ${id} - ${error.message}`); + logger.log('info', `Error while running a robot with id: ${id} - ${error.message}`); console.log(error.message); const run = await Run.findOne({ where: { runId: id } }); if (run) { @@ -232,7 +232,7 @@ export async function handleRunRecording(id: string, userId: string) { socket.on('ready-for-run', () => readyForRunHandler(browserId, newRunId)); - logger.log('info', `Running recording: ${id}`); + logger.log('info', `Running robot: ${id}`); socket.on('disconnect', () => { cleanupSocketListeners(socket, browserId, newRunId);