From 6815f1617b06e0ca0e35d3beaaf4eed152df125a Mon Sep 17 00:00:00 2001 From: karishmas6 Date: Tue, 23 Jul 2024 20:38:27 +0530 Subject: [PATCH] refactor: only handle highlighter state --- src/components/organisms/BrowserWindow.tsx | 30 ++-------------------- 1 file changed, 2 insertions(+), 28 deletions(-) diff --git a/src/components/organisms/BrowserWindow.tsx b/src/components/organisms/BrowserWindow.tsx index c516a776..18fec604 100644 --- a/src/components/organisms/BrowserWindow.tsx +++ b/src/components/organisms/BrowserWindow.tsx @@ -2,7 +2,6 @@ import React, { useCallback, useEffect, useState } from 'react'; import { useSocketStore } from '../../context/socket'; import Canvas from "../atoms/canvas"; import { useBrowserDimensionsStore } from "../../context/browserDimensions"; -import { Highlighter } from "../atoms/Highlighter"; export const BrowserWindow = () => { const [canvasRef, setCanvasReference] = useState | undefined>(undefined); @@ -12,20 +11,6 @@ export const BrowserWindow = () => { const { socket } = useSocketStore(); const { width, height } = useBrowserDimensionsStore(); - const onMouseMove = (e: MouseEvent) => { - if (canvasRef && canvasRef.current && highlighterData) { - const canvasRect = canvasRef.current.getBoundingClientRect(); - if ( - e.pageX < canvasRect.left - || e.pageX > canvasRect.right - || e.pageY < canvasRect.top - || e.pageY > canvasRect.bottom - ) { - setHighlighterData(null); - } - } - }; - const screencastHandler = useCallback((data: string) => { setScreenShot(data); }, []); @@ -47,27 +32,16 @@ export const BrowserWindow = () => { }, []) useEffect(() => { - document.addEventListener('mousemove', onMouseMove, false); if (socket) { socket.on("highlighter", highlighterHandler); } return () => { - document.removeEventListener('mousemove', onMouseMove); socket?.off("highlighter", highlighterHandler); }; - }, [socket, onMouseMove]); + }, [socket, highlighterHandler]); return ( -
- {(highlighterData?.rect != null && highlighterData?.rect.top != null) && canvasRef?.current ? - - : null} +