vodorod/parcer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #737 from getmaxun/multi-fix

Browse Source 
fix(maxun-core): remove workflow validation checks
This commit is contained in:
Karishma Shukla
2025-08-25 19:33:32 +05:30
committed by GitHub
parent 3568c3989b 8b8a08c54a
commit 663c1a25a7
1 changed files with 36 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

66
maxun-core/src/interpret.ts
View File

@@ -1169,31 +1169,36 @@ export default class Interpreter extends EventEmitter {
return; return;
} }
let pageState = {}; if (workflowCopy.length === 0) {
try { this.log('All actions completed. Workflow finished.', Level.LOG);
// Check if page is still valid before accessing state return;
if (p.isClosed()) {
this.log('Page was closed during execution', Level.WARN);
return;
}
pageState = await this.getState(p, workflowCopy, selectors);
selectors = [];
console.log("Empty selectors:", selectors)
} catch (e: any) {
this.log(`Failed to get page state: ${e.message}`, Level.ERROR);
// If state access fails, attempt graceful recovery
if (p.isClosed()) {
this.log('Browser has been closed, terminating workflow', Level.WARN);
return;
}
// For other errors, continue with empty state to avoid complete failure
pageState = { url: p.url(), selectors: [], cookies: {} };
} }
if (this.options.debug) { // let pageState = {};
this.log(`Current state is: \n${JSON.stringify(pageState, null, 2)}`, Level.WARN); // try {
} // // Check if page is still valid before accessing state
// if (p.isClosed()) {
// this.log('Page was closed during execution', Level.WARN);
// return;
// }
// pageState = await this.getState(p, workflowCopy, selectors);
// selectors = [];
// console.log("Empty selectors:", selectors)
// } catch (e: any) {
// this.log(`Failed to get page state: ${e.message}`, Level.ERROR);
// // If state access fails, attempt graceful recovery
// if (p.isClosed()) {
// this.log('Browser has been closed, terminating workflow', Level.WARN);
// return;
// }
// // For other errors, continue with empty state to avoid complete failure
// pageState = { url: p.url(), selectors: [], cookies: {} };
// }
// if (this.options.debug) {
// this.log(`Current state is: \n${JSON.stringify(pageState, null, 2)}`, Level.WARN);
// }
// const actionId = workflow.findIndex((step) => { // const actionId = workflow.findIndex((step) => {
// const isApplicable = this.applicable(step.where, pageState, usedActions); // const isApplicable = this.applicable(step.where, pageState, usedActions);
@@ -1205,8 +1210,9 @@ export default class Interpreter extends EventEmitter {
// return isApplicable; // return isApplicable;
// }); // });
actionId = this.getMatchingActionId(workflowCopy, pageState, usedActions); // actionId = this.getMatchingActionId(workflowCopy, pageState, usedActions);
const actionId = workflowCopy.length - 1;
const action = workflowCopy[actionId]; const action = workflowCopy[actionId];
console.log("MATCHED ACTION:", action); console.log("MATCHED ACTION:", action);
@@ -1235,12 +1241,12 @@ export default class Interpreter extends EventEmitter {
console.log(`Action with ID ${action.id} removed from the workflow copy.`); console.log(`Action with ID ${action.id} removed from the workflow copy.`);
// const newSelectors = this.getPreviousSelectors(workflow, actionId); // const newSelectors = this.getPreviousSelectors(workflow, actionId);
const newSelectors = this.getSelectors(workflowCopy); // const newSelectors = this.getSelectors(workflowCopy);
newSelectors.forEach(selector => { // newSelectors.forEach(selector => {
if (!selectors.includes(selector)) { // if (!selectors.includes(selector)) {
selectors.push(selector); // selectors.push(selector);
} // }
}); // });
// Reset loop iteration counter on successful action // Reset loop iteration counter on successful action
loopIterations = 0; loopIterations = 0;