Merge pull request #874 from getmaxun/recorder-ui-shift

fix: unwanted overflow in recorder
This commit is contained in:
Karishma Shukla
2025-11-12 22:09:29 +05:30
committed by GitHub
4 changed files with 16 additions and 15 deletions

View File

@@ -143,7 +143,8 @@ const BrowserRecordingSave = () => {
overflow: 'hidden', overflow: 'hidden',
display: 'flex', display: 'flex',
justifyContent: 'space-between', justifyContent: 'space-between',
height: "48px" height: "48px",
marginLeft: '10px'
}}> }}>
<Button <Button
onClick={() => setOpenDiscardModal(true)} onClick={() => setOpenDiscardModal(true)}

View File

@@ -534,7 +534,7 @@ export const RightSidePanel: React.FC<RightSidePanelProps> = ({ onFinishCapture
const isDarkMode = theme.darkMode; const isDarkMode = theme.darkMode;
return ( return (
<Paper sx={{ height: panelHeight, width: 'auto', alignItems: "center", background: 'inherit' }} id="browser-actions" elevation={0}> <Paper sx={{ height: panelHeight, width: 'auto', alignItems: "center", background: 'inherit', position: "relative", border: "none" }} id="browser-actions" elevation={0}>
<ActionDescriptionBox isDarkMode={isDarkMode} /> <ActionDescriptionBox isDarkMode={isDarkMode} />
<Box display="flex" flexDirection="column" gap={2} style={{ margin: '13px' }}> <Box display="flex" flexDirection="column" gap={2} style={{ margin: '13px' }}>
{!isAnyActionActive && ( {!isAnyActionActive && (

View File

@@ -73,7 +73,7 @@ export const getResponsiveDimensions = (): AppDimensions => {
browserWidth, browserWidth,
browserHeight, browserHeight,
panelHeight: browserHeight + 137, panelHeight: browserHeight + 137,
outputPreviewHeight: windowHeight * 0.7, outputPreviewHeight: windowHeight * 0.9,
outputPreviewWidth, outputPreviewWidth,
canvasWidth: browserWidth, canvasWidth: browserWidth,
canvasHeight: browserHeight canvasHeight: browserHeight

View File

@@ -55,7 +55,7 @@ export const PageWrapper = () => {
const sessionParam = urlParams.get('session'); const sessionParam = urlParams.get('session');
const storedSessionId = getTabState('recordingSessionId'); const storedSessionId = getTabState('recordingSessionId');
const storedRecordingUrl = getTabState('recordingUrl'); const storedRecordingUrl = getTabState('recordingUrl');
if (location.pathname === '/recording-setup' && sessionParam && sessionParam === storedSessionId) { if (location.pathname === '/recording-setup' && sessionParam && sessionParam === storedSessionId) {
setBrowserId('new-recording'); setBrowserId('new-recording');
setRecordingName(''); setRecordingName('');
@@ -67,14 +67,14 @@ export const PageWrapper = () => {
navigate('/recording'); navigate('/recording');
} }
else if (location.pathname === '/recording' || else if (location.pathname === '/recording' ||
(getTabState('nextTabIsRecording') === 'true' && sessionParam === storedSessionId)) { (getTabState('nextTabIsRecording') === 'true' && sessionParam === storedSessionId)) {
setIsRecordingMode(true); setIsRecordingMode(true);
if (location.pathname !== '/recording') { if (location.pathname !== '/recording') {
navigate('/recording'); navigate('/recording');
} }
window.sessionStorage.removeItem('nextTabIsRecording'); window.sessionStorage.removeItem('nextTabIsRecording');
} else if (tabMode === 'main') { } else if (tabMode === 'main') {
console.log('Tab is in main application mode'); console.log('Tab is in main application mode');
@@ -88,7 +88,7 @@ export const PageWrapper = () => {
const isAuthPage = location.pathname === '/login' || location.pathname === '/register'; const isAuthPage = location.pathname === '/login' || location.pathname === '/register';
const isRecordingPage = location.pathname === '/recording'; const isRecordingPage = location.pathname === '/recording';
return ( return (
<div> <div>
<AuthProvider> <AuthProvider>
@@ -96,18 +96,18 @@ export const PageWrapper = () => {
<React.Fragment> <React.Fragment>
{/* Show NavBar only for main app pages, not for recording pages */} {/* Show NavBar only for main app pages, not for recording pages */}
{!isRecordingPage && ( {!isRecordingPage && (
<Box sx={{ <Box sx={{
position: 'sticky', position: 'sticky',
top: 0, top: 0,
zIndex: 1100, zIndex: 1100,
backgroundColor: 'background.paper' backgroundColor: 'background.paper'
}}> }}>
<NavBar recordingName={recordingName} isRecording={false} /> <NavBar recordingName={recordingName} isRecording={false} />
</Box> </Box>
)} )}
<Box sx={{ <Box sx={{
display: isAuthPage || isRecordingPage ? 'block' : 'flex', display: isAuthPage ? 'block' : 'flex',
minHeight: isAuthPage || isRecordingPage ? '100vh' : 'calc(100vh - 64px)' minHeight: isAuthPage ? '100vh' : 'calc(100vh - 64px)'
}}> }}>
<Routes> <Routes>
<Route element={<UserRoute />}> <Route element={<UserRoute />}>