vodorod/parcer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #486 from getmaxun/link-fix

Browse Source 
fix: attribute selection on link selections
This commit is contained in:
Karishma Shukla
2025-03-19 16:47:05 +05:30
committed by GitHub
parent 39022a5316 194b8bbb72
commit 2497e7ba67
1 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
server/src/workflow-management/selector.ts
View File

@@ -155,10 +155,8 @@ export const getElementInformation = async (
if (el) { if (el) {
// Prioritize Link (DO NOT REMOVE) // Prioritize Link (DO NOT REMOVE)
// const { parentElement } = el; const { parentElement } = el;
// const targetElement = parentElement?.tagName === 'A' ? parentElement : el; const targetElement = parentElement?.tagName === 'A' ? parentElement : el;
const targetElement = el;
const ownerDocument = targetElement.ownerDocument; const ownerDocument = targetElement.ownerDocument;
const frameElement = ownerDocument?.defaultView?.frameElement as HTMLIFrameElement; const frameElement = ownerDocument?.defaultView?.frameElement as HTMLIFrameElement;
@@ -705,10 +703,9 @@ export const getRect = async (page: Page, coordinates: Coordinates, listSelector
const el = getDeepestElementFromPoint(x, y); const el = getDeepestElementFromPoint(x, y);
if (el) { if (el) {
// Prioritize Link (DO NOT REMOVE) // Prioritize Link (DO NOT REMOVE)
// const { parentElement } = el; const { parentElement } = el;
// const element = parentElement?.tagName === 'A' ? parentElement : el; const element = parentElement?.tagName === 'A' ? parentElement : el;
const element = el;
const rectangle = element?.getBoundingClientRect(); const rectangle = element?.getBoundingClientRect();
if (rectangle) { if (rectangle) {
const createRectObject = (rect: DOMRect) => ({ const createRectObject = (rect: DOMRect) => ({
@@ -1882,11 +1879,10 @@ export const getSelectors = async (page: Page, coordinates: Coordinates) => {
!hoveredElement.closest('#overlay-controls') != null !hoveredElement.closest('#overlay-controls') != null
) { ) {
// Prioritize Link (DO NOT REMOVE) // Prioritize Link (DO NOT REMOVE)
// const { parentElement } = hoveredElement; const { parentElement } = hoveredElement;
// Match the logic in recorder.ts for link clicks // Match the logic in recorder.ts for link clicks
// const element = parentElement?.tagName === 'A' ? parentElement : hoveredElement; const element = parentElement?.tagName === 'A' ? parentElement : hoveredElement;
const element = hoveredElement;
const generatedSelectors = genSelectors(element); const generatedSelectors = genSelectors(element);
return generatedSelectors; return generatedSelectors;
} }