From 5be117247492bf2ce50e1d96d6f1826ed70ecf7f Mon Sep 17 00:00:00 2001 From: Rohit Date: Tue, 29 Apr 2025 00:47:05 +0530 Subject: [PATCH 1/2] feat: destroy browser fallback fix --- server/src/routes/record.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/server/src/routes/record.ts b/server/src/routes/record.ts index 411767c2..cee9d4ae 100644 --- a/server/src/routes/record.ts +++ b/server/src/routes/record.ts @@ -10,6 +10,7 @@ import { getRemoteBrowserCurrentUrl, getRemoteBrowserCurrentTabs, getActiveBrowserIdByState, + destroyRemoteBrowser, } from '../browser-management/controller'; import { chromium } from 'playwright-extra'; import stealthPlugin from 'puppeteer-extra-plugin-stealth'; @@ -146,8 +147,8 @@ router.get('/stop/:browserId', requireSignIn, async (req: AuthenticatedRequest, }); if (!jobId) { - const browserId = initializeRemoteBrowserForRecording(req.user.id); - return res.send( browserId ); + await destroyRemoteBrowser(req.user.id, req.user.id); + return res.send(false); } logger.log('info', `Queued browser destruction job: ${jobId}, waiting for completion...`); From 863603fac39fbf7295d38207a40dd317dbb7c4b8 Mon Sep 17 00:00:00 2001 From: Rohit Date: Tue, 29 Apr 2025 00:50:12 +0530 Subject: [PATCH 2/2] feat: pass browser id --- server/src/routes/record.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/routes/record.ts b/server/src/routes/record.ts index cee9d4ae..374f837a 100644 --- a/server/src/routes/record.ts +++ b/server/src/routes/record.ts @@ -147,7 +147,7 @@ router.get('/stop/:browserId', requireSignIn, async (req: AuthenticatedRequest, }); if (!jobId) { - await destroyRemoteBrowser(req.user.id, req.user.id); + await destroyRemoteBrowser(req.params.browserId, req.user.id); return res.send(false); }