From fc4c9715bfcb67f6edf769fa8e8ef1b545bed057 Mon Sep 17 00:00:00 2001 From: Shuchang Zheng Date: Thu, 13 Mar 2025 10:39:57 -0700 Subject: [PATCH] it's okay to have null password and we just show it as an empty string (#1933) --- skyvern/forge/sdk/services/bitwarden.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/skyvern/forge/sdk/services/bitwarden.py b/skyvern/forge/sdk/services/bitwarden.py index 5eb7a2e6..58439ea8 100644 --- a/skyvern/forge/sdk/services/bitwarden.py +++ b/skyvern/forge/sdk/services/bitwarden.py @@ -61,8 +61,8 @@ def get_list_response_item_from_bitwarden_item(item: dict) -> CredentialItem: return CredentialItem( item_id=item["id"], credential=PasswordCredential( - username=login["username"], - password=login["password"], + username=login["username"] or "", + password=login["password"] or "", totp=login["totp"], ), name=item["name"], @@ -742,8 +742,8 @@ class BitwardenService: raise BitwardenGetItemError(f"Item with ID: {item_id} is not a login item") return PasswordCredential( - username=login["username"], - password=login["password"], + username=login["username"] or "", + password=login["password"] or "", totp=login["totp"], ) @@ -981,8 +981,8 @@ class BitwardenService: credential_type=CredentialType.PASSWORD, name=name, credential=PasswordCredential( - username=login_item["username"], - password=login_item["password"], + username=login_item["username"] or "", + password=login_item["password"] or "", totp=login_item["totp"], ), )