vodorod/Dorod-Sky
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

make log_exception optional for s3 file download - there are expected cases when the file is not there and the function returns None (#511)

Browse Source
This commit is contained in:
Shuchang Zheng
2024-06-25 10:21:28 -07:00
committed by GitHub
parent ccaf34c49b
commit f2ceb9f88d
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
skyvern/forge/sdk/api/aws.py
View File

@@ -65,13 +65,14 @@ class AsyncAWSClient:
LOG.exception("S3 upload failed.", uri=uri) LOG.exception("S3 upload failed.", uri=uri)
@execute_with_async_client(client_type=AWSClientType.S3) @execute_with_async_client(client_type=AWSClientType.S3)
async def download_file(self, uri: str, client: AioBaseClient = None) -> bytes | None: async def download_file(self, uri: str, client: AioBaseClient = None, log_exception: bool = True) -> bytes | None:
try: try:
parsed_uri = S3Uri(uri) parsed_uri = S3Uri(uri)
response = await client.get_object(Bucket=parsed_uri.bucket, Key=parsed_uri.key) response = await client.get_object(Bucket=parsed_uri.bucket, Key=parsed_uri.key)
return await response["Body"].read() return await response["Body"].read()
except Exception: except Exception:
LOG.exception("S3 download failed", uri=uri) if log_exception:
LOG.exception("S3 download failed", uri=uri)
return None return None
@execute_with_async_client(client_type=AWSClientType.S3) @execute_with_async_client(client_type=AWSClientType.S3)