From ed57878328662860ef5051810e0b4332b012924a Mon Sep 17 00:00:00 2001
From: Kerem Yilmaz <kerem@skyvern.com>
Date: Thu, 12 Sep 2024 00:59:01 -0700
Subject: [PATCH] Add download suffix to workflow editor (#817)

---
 .../editor/nodes/TaskNode/TaskNode.tsx        | 20 ++++++++++++++++++-
 .../workflows/editor/nodes/TaskNode/types.ts  |  2 ++
 .../workflows/editor/workflowEditorUtils.ts   |  2 ++
 .../routes/workflows/types/workflowTypes.ts   |  1 +
 .../workflows/types/workflowYamlTypes.ts      |  1 +
 5 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNode.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNode.tsx
index 8fda30b4..326743e4 100644
--- a/skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNode.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNode.tsx
@@ -41,6 +41,7 @@ function TaskNode({ id, data }: NodeProps<TaskNode>) {
     maxRetries: data.maxRetries,
     maxStepsOverride: data.maxStepsOverride,
     allowDownloads: data.allowDownloads,
+    downloadSuffix: data.downloadSuffix,
     errorCodeMapping: data.errorCodeMapping,
     totpVerificationUrl: data.totpVerificationUrl,
     totpIdentifier: data.totpIdentifier,
@@ -224,7 +225,7 @@ function TaskNode({ id, data }: NodeProps<TaskNode>) {
                   }}
                 />
               </div>
-              <div className="flex justify-between">
+              <div className="flex items-center justify-between">
                 <Label className="text-xs font-normal text-slate-300">
                   Allow Downloads
                 </Label>
@@ -240,6 +241,23 @@ function TaskNode({ id, data }: NodeProps<TaskNode>) {
                   />
                 </div>
               </div>
+              <div className="flex items-center justify-between">
+                <Label className="text-xs font-normal text-slate-300">
+                  Download Suffix
+                </Label>
+                <Input
+                  type="text"
+                  placeholder="Suffix"
+                  className="nopan w-44"
+                  value={inputs.downloadSuffix ?? ""}
+                  onChange={(event) => {
+                    if (!editable) {
+                      return;
+                    }
+                    handleChange("downloadSuffix", event.target.value);
+                  }}
+                />
+              </div>
               <div className="space-y-2">
                 <div className="flex gap-2">
                   <Label className="text-xs font-normal text-slate-300">
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/types.ts b/skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/types.ts
index 81a510bc..9b31ec2e 100644
--- a/skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/types.ts
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/types.ts
@@ -9,6 +9,7 @@ export type TaskNodeData = {
   maxRetries: number | null;
   maxStepsOverride: number | null;
   allowDownloads: boolean;
+  downloadSuffix: string | null;
   editable: boolean;
   label: string;
   parameterKeys: Array<string>;
@@ -29,6 +30,7 @@ export const taskNodeDefaultData: TaskNodeData = {
   maxRetries: null,
   maxStepsOverride: null,
   allowDownloads: false,
+  downloadSuffix: null,
   editable: true,
   label: "",
   parameterKeys: [],
diff --git a/skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts b/skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts
index 75fa1279..2dcd6fa9 100644
--- a/skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts
+++ b/skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts
@@ -111,6 +111,7 @@ function convertToNode(
           dataSchema: JSON.stringify(block.data_schema, null, 2),
           errorCodeMapping: JSON.stringify(block.error_code_mapping, null, 2),
           allowDownloads: block.complete_on_download ?? false,
+          downloadSuffix: block.download_suffix ?? null,
           maxRetries: block.max_retries ?? null,
           maxStepsOverride: block.max_steps_per_run ?? null,
           parameterKeys: block.parameters.map((p) => p.key),
@@ -451,6 +452,7 @@ function getWorkflowBlock(
         max_retries: node.data.maxRetries ?? undefined,
         max_steps_per_run: node.data.maxStepsOverride,
         complete_on_download: node.data.allowDownloads,
+        download_suffix: node.data.downloadSuffix,
         parameter_keys: node.data.parameterKeys,
         totp_identifier: node.data.totpIdentifier,
         totp_verification_url: node.data.totpVerificationUrl,
diff --git a/skyvern-frontend/src/routes/workflows/types/workflowTypes.ts b/skyvern-frontend/src/routes/workflows/types/workflowTypes.ts
index 001a529b..c98c20de 100644
--- a/skyvern-frontend/src/routes/workflows/types/workflowTypes.ts
+++ b/skyvern-frontend/src/routes/workflows/types/workflowTypes.ts
@@ -134,6 +134,7 @@ export type TaskBlock = WorkflowBlockBase & {
   max_steps_per_run?: number | null;
   parameters: Array<WorkflowParameter>;
   complete_on_download?: boolean;
+  download_suffix?: string | null;
   totp_verification_url?: string | null;
   totp_identifier?: string | null;
 };
diff --git a/skyvern-frontend/src/routes/workflows/types/workflowYamlTypes.ts b/skyvern-frontend/src/routes/workflows/types/workflowYamlTypes.ts
index ea6c873c..5675f4b8 100644
--- a/skyvern-frontend/src/routes/workflows/types/workflowYamlTypes.ts
+++ b/skyvern-frontend/src/routes/workflows/types/workflowYamlTypes.ts
@@ -79,6 +79,7 @@ export type TaskBlockYAML = BlockYAMLBase & {
   max_steps_per_run?: number | null;
   parameter_keys?: Array<string> | null;
   complete_on_download?: boolean;
+  download_suffix?: string | null;
   totp_verification_url?: string | null;
   totp_identifier?: string | null;
 };