vodorod/Dorod-Sky
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix totp identifier fallback from stored credentials (#4190)

Browse Source
This commit is contained in:
Marc Kelechava
2025-12-03 19:17:23 -08:00
committed by GitHub
parent ea3fa7c306
commit eca4c68dd6
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
skyvern/forge/sdk/workflow/context_manager.py
View File

@@ -296,7 +296,7 @@ class WorkflowRunContext:
credential_item = await credential_service.get_credential_item(db_credential) credential_item = await credential_service.get_credential_item(db_credential)
credential = credential_item.credential credential = credential_item.credential
credential_totp_identifier = getattr(credential, "totp_identifier", None) credential_totp_identifier = db_credential.totp_identifier or getattr(credential, "totp_identifier", None)
if credential_totp_identifier: if credential_totp_identifier:
self.credential_totp_identifiers[parameter.key] = credential_totp_identifier self.credential_totp_identifiers[parameter.key] = credential_totp_identifier

9
skyvern/forge/sdk/workflow/models/block.py
View File

@@ -3493,6 +3493,13 @@ class TaskV2Block(Block):
max_iterations: int = settings.MAX_ITERATIONS_PER_TASK_V2 max_iterations: int = settings.MAX_ITERATIONS_PER_TASK_V2
max_steps: int = settings.MAX_STEPS_PER_TASK_V2 max_steps: int = settings.MAX_STEPS_PER_TASK_V2
def _resolve_totp_identifier(self, workflow_run_context: WorkflowRunContext) -> str | None:
if self.totp_identifier:
return self.totp_identifier
if workflow_run_context.credential_totp_identifiers:
return next(iter(workflow_run_context.credential_totp_identifiers.values()), None)
return None
def get_all_parameters( def get_all_parameters(
self, self,
workflow_run_id: str, workflow_run_id: str,
@@ -3535,7 +3542,7 @@ class TaskV2Block(Block):
# Use the resolved values directly # Use the resolved values directly
resolved_prompt = self.prompt resolved_prompt = self.prompt
resolved_url = self.url resolved_url = self.url
resolved_totp_identifier = self.totp_identifier resolved_totp_identifier = self._resolve_totp_identifier(workflow_run_context)
resolved_totp_verification_url = self.totp_verification_url resolved_totp_verification_url = self.totp_verification_url
except Exception as e: except Exception as e: