From d69e15ab6520d736eed00d9becfa312e261d496c Mon Sep 17 00:00:00 2001 From: Shuchang Zheng Date: Thu, 12 Jun 2025 13:17:50 -0700 Subject: [PATCH] SKYVERN_BROWSER_VNC_PORT (#2702) --- skyvern/config.py | 6 ++++++ skyvern/forge/sdk/routes/streaming_vnc.py | 8 +++----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/skyvern/config.py b/skyvern/config.py index 7324bc4e..dc19055f 100644 --- a/skyvern/config.py +++ b/skyvern/config.py @@ -265,6 +265,12 @@ class Settings(BaseSettings): SKYVERN_BASE_URL: str = "https://api.skyvern.com" SKYVERN_API_KEY: str = "PLACEHOLDER" + SKYVERN_BROWSER_VNC_PORT: int = 6080 + """ + The websockified port on which the VNC server of a persistent browser is + listening. + """ + def get_model_name_to_llm_key(self) -> dict[str, dict[str, str]]: """ Keys are model names available to blocks in the frontend. These map to key names diff --git a/skyvern/forge/sdk/routes/streaming_vnc.py b/skyvern/forge/sdk/routes/streaming_vnc.py index f3b05657..bfcb1ed1 100644 --- a/skyvern/forge/sdk/routes/streaming_vnc.py +++ b/skyvern/forge/sdk/routes/streaming_vnc.py @@ -5,12 +5,12 @@ from enum import IntEnum import structlog import websockets -from cloud.config import settings from fastapi import WebSocket, WebSocketDisconnect from starlette.websockets import WebSocketState from websockets import Data from websockets.exceptions import ConnectionClosedError, ConnectionClosedOK +from skyvern.config import settings from skyvern.forge import app from skyvern.forge.sdk.routes.routers import legacy_base_router from skyvern.forge.sdk.schemas.persistent_browser_sessions import AddressablePersistentBrowserSession @@ -184,9 +184,8 @@ async def get_streaming_for_task( streaming = Streaming( interactor="user", organization_id=organization_id, - vnc_port=settings.PERSISTENT_BROWSER_VNC_PORT, + vnc_port=settings.SKYVERN_BROWSER_VNC_PORT, websocket=websocket, - # -- browser_session=browser_session, task=task, ) @@ -230,8 +229,7 @@ async def get_streaming_for_workflow_run( streaming = Streaming( interactor="user", organization_id=organization_id, - vnc_port=settings.PERSISTENT_BROWSER_VNC_PORT, - # -- + vnc_port=settings.SKYVERN_BROWSER_VNC_PORT, browser_session=browser_session, workflow_run=workflow_run, websocket=websocket,