From d54c2af544e4aadba2953d32fae4258094e74379 Mon Sep 17 00:00:00 2001 From: Shuchang Zheng Date: Sun, 30 Mar 2025 17:36:55 -0700 Subject: [PATCH] use the BROWSER_REMOTE_DEBUGGING_URL for cdp connect directly (#2040) --- skyvern/webeye/browser_factory.py | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/skyvern/webeye/browser_factory.py b/skyvern/webeye/browser_factory.py index 66db458d..86f886e7 100644 --- a/skyvern/webeye/browser_factory.py +++ b/skyvern/webeye/browser_factory.py @@ -9,7 +9,6 @@ from pathlib import Path from typing import Any, Awaitable, Callable, Protocol import aiofiles -import httpx import structlog from playwright.async_api import BrowserContext, ConsoleMessage, Download, Page, Playwright from pydantic import BaseModel, PrivateAttr @@ -359,21 +358,7 @@ async def _create_cdp_connection_browser( har_path=browser_args["record_har_path"], ) - remote_browser_url = None - try: - async with httpx.AsyncClient() as client: - response = await client.get(f"{settings.BROWSER_REMOTE_DEBUGGING_URL}/json/version") - remote_browser_url = response.json().get("webSocketDebuggerUrl") - except Exception: - raise Exception( - f"Cannot find the webSocketDebuggerUrl from the browser remote debugging {settings.BROWSER_REMOTE_DEBUGGING_URL}" - ) - - if not remote_browser_url: - raise Exception( - f"Cannot find the webSocketDebuggerUrl from the browser remote debugging {settings.BROWSER_REMOTE_DEBUGGING_URL}" - ) - + remote_browser_url = settings.BROWSER_REMOTE_DEBUGGING_URL LOG.info("Connecting browser CDP connection", remote_browser_url=remote_browser_url) browser = await playwright.chromium.connect_over_cdp(remote_browser_url)