Add shell check to pre-cmmit hooks & fix issues reported by it (#2579)

.pre-commit-config.yaml

@@ -97,3 +97,8 @@ repos:
         entry: ./run_alembic_check.sh
         language: script
         stages: [ manual ]
+  - repo: https://github.com/koalaman/shellcheck-precommit
+    rev: v0.10.0
+    hooks:
+      - id: shellcheck
+

entrypoint-skyvern.sh

@@ -1,4 +1,3 @@
-
 #!/bin/bash
 
 set -e

entrypoint-skyvernui.sh

@@ -1,11 +1,10 @@
-
 #!/bin/bash
 
 set -e
 
 # setting api key
-export VITE_SKYVERN_API_KEY=$(sed -n 's/.*cred\s*=\s*"\([^"]*\)".*/\1/p' .streamlit/secrets.toml)
+VITE_SKYVERN_API_KEY=$(sed -n 's/.*cred\s*=\s*"\([^"]*\)".*/\1/p' .streamlit/secrets.toml)
-
+export VITE_SKYVERN_API_KEY
 npm run start
 
 

run_alembic_check.sh

@@ -1,6 +1,6 @@
 #!/bin/sh
 # first apply migrations
-export PATH=$PATH:.venv/bin
+export PATH="${PATH}:.venv/bin"
 alembic upgrade head
 # then check if the database is up to date with the models
 alembic check

run_skyvern.sh

@@ -1,14 +1,15 @@
 #!/bin/bash
 
 pid=$(lsof -t -i :8000)
-if [ ! -z "$pid" ]; then
+if [ -n "$pid" ]; then
-  kill $pid
+  kill "$pid"
 fi
 
 if [ ! -f .env ]; then
   cp .env.example .env
   echo "Please add your api keys to the .env file."
 fi
+# shellcheck source=/dev/null
 source "$(poetry env info --path)/bin/activate"
 poetry install
 ./run_alembic_check.sh

run_ui.sh

@@ -1,11 +1,11 @@
 #!/bin/bash
 
 pid=$(lsof -t -i :8080)
-if [ ! -z "$pid" ]; then
+if [ -n "$pid" ]; then
-  kill $pid
+  kill "$pid"
 fi
 
-cd skyvern-frontend
+cd skyvern-frontend || exit 1
 
 if [ ! -f .env ]; then
   cp .env.example .env