vodorod/Dorod-Sky
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Only notify with actual changes (#1173)

Browse Source
This commit is contained in:
Shuchang Zheng
2024-11-11 10:41:10 -08:00
committed by GitHub
parent b768ca0e86
commit c1c2b5ca24
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
skyvern-frontend/src/hooks/useShouldNotifyWhenClosingTab.ts
View File

@@ -1,13 +1,14 @@
import { useEffect } from "react"; import { useEffect } from "react";
function useShouldNotifyWhenClosingTab() { function useShouldNotifyWhenClosingTab(shouldNotify: boolean) {
useEffect(() => { useEffect(() => {
function f(event: BeforeUnloadEvent) { function f(event: BeforeUnloadEvent) {
// this function is here to have a stable reference only // this function is here to have a stable reference only
if (!shouldNotify) {
return undefined;
}
// Recommended // Recommended
event.preventDefault(); event.preventDefault();
// Included for legacy support, e.g. Chrome/Edge < 119 // Included for legacy support, e.g. Chrome/Edge < 119
// refer to https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event // refer to https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event
event.returnValue = true; event.returnValue = true;
@@ -18,7 +19,7 @@ function useShouldNotifyWhenClosingTab() {
return () => { return () => {
window.removeEventListener("beforeunload", f); window.removeEventListener("beforeunload", f);
}; };
}, []); }, [shouldNotify]);
} }
export { useShouldNotifyWhenClosingTab }; export { useShouldNotifyWhenClosingTab };

2
skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx
View File

@@ -191,7 +191,7 @@ function FlowRenderer({
const [title, setTitle] = useState(initialTitle); const [title, setTitle] = useState(initialTitle);
const nodesInitialized = useNodesInitialized(); const nodesInitialized = useNodesInitialized();
const { hasChanges, setHasChanges } = useWorkflowHasChangesStore(); const { hasChanges, setHasChanges } = useWorkflowHasChangesStore();
useShouldNotifyWhenClosingTab(); useShouldNotifyWhenClosingTab(hasChanges);
const blocker = useBlocker(({ currentLocation, nextLocation }) => { const blocker = useBlocker(({ currentLocation, nextLocation }) => {
return hasChanges && nextLocation.pathname !== currentLocation.pathname; return hasChanges && nextLocation.pathname !== currentLocation.pathname;
}); });