vodorod/Dorod-Sky
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Respect disable goal check in parallel flow (#4021)

Browse Source
This commit is contained in:
pedrohsdb
2025-11-21 15:07:50 -08:00
committed by GitHub
parent d96de3b7a2
commit c10016c8bc
1 changed files with 37 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
skyvern/forge/agent.py
View File

@@ -1561,10 +1561,13 @@ class ForgeAgent:
# Check if parallel verification is enabled # Check if parallel verification is enabled
distinct_id = task.workflow_run_id if task.workflow_run_id else task.task_id distinct_id = task.workflow_run_id if task.workflow_run_id else task.task_id
enable_parallel_verification = await app.EXPERIMENTATION_PROVIDER.is_feature_enabled_cached( enable_parallel_verification = (
"ENABLE_PARALLEL_USER_GOAL_CHECK", await app.EXPERIMENTATION_PROVIDER.is_feature_enabled_cached(
distinct_id, "ENABLE_PARALLEL_USER_GOAL_CHECK",
properties={"organization_id": task.organization_id, "task_url": task.url}, distinct_id,
properties={"organization_id": task.organization_id, "task_url": task.url},
)
and not disable_user_goal_check
) )
if not disable_user_goal_check and not enable_parallel_verification: if not disable_user_goal_check and not enable_parallel_verification:
@@ -1590,7 +1593,7 @@ class ForgeAgent:
) )
detailed_agent_step_output.actions_and_results.append((complete_action, complete_results)) detailed_agent_step_output.actions_and_results.append((complete_action, complete_results))
await self.record_artifacts_after_action(task, step, browser_state, engine) await self.record_artifacts_after_action(task, step, browser_state, engine)
elif enable_parallel_verification: elif not disable_user_goal_check and enable_parallel_verification:
# Parallel verification enabled - defer check to handle_completed_step # Parallel verification enabled - defer check to handle_completed_step
LOG.info( LOG.info(
"Parallel verification enabled, deferring user goal check to handle_completed_step", "Parallel verification enabled, deferring user goal check to handle_completed_step",
@@ -4204,29 +4207,42 @@ class ForgeAgent:
if should_verify and browser_state and scraped_page: if should_verify and browser_state and scraped_page:
try: try:
distinct_id = task.workflow_run_id if task.workflow_run_id else task.task_id disable_user_goal_check = await app.EXPERIMENTATION_PROVIDER.is_feature_enabled_cached(
enable_parallel_verification = await app.EXPERIMENTATION_PROVIDER.is_feature_enabled_cached( "DISABLE_USER_GOAL_CHECK",
"ENABLE_PARALLEL_USER_GOAL_CHECK", task.workflow_run_id if task.workflow_run_id else task.task_id,
distinct_id, properties={"task_url": task.url, "organization_id": task.organization_id},
properties={"organization_id": task.organization_id, "task_url": task.url},
) )
if enable_parallel_verification: if disable_user_goal_check:
LOG.info( LOG.info(
"Parallel verification enabled, using optimized flow", "User goal verification disabled via feature flag, skipping parallel verification",
step_id=step.step_id, step_id=step.step_id,
task_id=task.task_id, task_id=task.task_id,
) )
return await self._handle_completed_step_with_parallel_verification( else:
organization=organization, distinct_id = task.workflow_run_id if task.workflow_run_id else task.task_id
task=task, enable_parallel_verification = await app.EXPERIMENTATION_PROVIDER.is_feature_enabled_cached(
step=step, "ENABLE_PARALLEL_USER_GOAL_CHECK",
page=page, distinct_id,
browser_state=browser_state, properties={"organization_id": task.organization_id, "task_url": task.url},
scraped_page=scraped_page,
engine=engine,
task_block=task_block,
) )
if enable_parallel_verification:
LOG.info(
"Parallel verification enabled, using optimized flow",
step_id=step.step_id,
task_id=task.task_id,
)
return await self._handle_completed_step_with_parallel_verification(
organization=organization,
task=task,
step=step,
page=page,
browser_state=browser_state,
scraped_page=scraped_page,
engine=engine,
task_block=task_block,
)
except Exception: except Exception:
LOG.warning( LOG.warning(
"Failed to check parallel verification feature flag, using standard flow", "Failed to check parallel verification feature flag, using standard flow",