From b93154e7b7fa18d224807ddf91182183f6917af9 Mon Sep 17 00:00:00 2001
From: Shuchang Zheng <wintonzheng0325@gmail.com>
Date: Thu, 16 Oct 2025 02:14:32 -0700
Subject: [PATCH] fix file upload files (#3735)

---
 skyvern/core/script_generations/skyvern_page.py | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/skyvern/core/script_generations/skyvern_page.py b/skyvern/core/script_generations/skyvern_page.py
index c0b36801..d01513dc 100644
--- a/skyvern/core/script_generations/skyvern_page.py
+++ b/skyvern/core/script_generations/skyvern_page.py
@@ -780,7 +780,6 @@ class SkyvernPage:
         self,
         selector: str,
         files: str,
-        file_path: str,
         intention: str,
         data: str | dict[str, Any] | None = None,
         timeout: float = settings.BROWSER_ACTION_TIMEOUT_MS,
@@ -806,6 +805,7 @@ class SkyvernPage:
                 LOG.exception(f"Failed to adapt value for input text action on selector={selector}, file={files}")
         if not files:
             raise ValueError("file url must be provided")
+        file_path = await download_file(files)
         locator = self.page.locator(selector)
         await locator.set_input_files(file_path, timeout=timeout)
         return files
@@ -820,10 +820,10 @@ class SkyvernPage:
         data: str | dict[str, Any] | None = None,
         timeout: float = settings.BROWSER_ACTION_TIMEOUT_MS,
     ) -> str:
-        file_path = await download_file(files)
         if ai == "fallback":
             error_to_raise = None
             try:
+                file_path = await download_file(files)
                 locator = self.page.locator(selector)
                 await locator.set_input_files(file_path)
             except Exception as e:
@@ -832,7 +832,6 @@ class SkyvernPage:
                 return await self._ai_upload_file(
                     selector=selector,
                     files=files,
-                    file_path=file_path,
                     intention=intention,
                     data=data,
                     timeout=timeout,
@@ -845,11 +844,11 @@ class SkyvernPage:
             return await self._ai_upload_file(
                 selector=selector,
                 files=files,
-                file_path=file_path,
                 intention=intention,
                 data=data,
                 timeout=timeout,
             )
+        file_path = await download_file(files)
         locator = self.page.locator(selector)
         await locator.set_input_files(file_path, timeout=timeout)
         return files