remove exc_info from LOG.exception (#246)

This commit is contained in:
Shuchang Zheng
2024-04-30 00:27:32 -07:00
committed by GitHub
parent 45d11e5a7f
commit b6a85cf3a5
8 changed files with 20 additions and 22 deletions

View File

@@ -302,7 +302,6 @@ class ForgeAgent:
except FailedToSendWebhook:
LOG.exception(
"Failed to send webhook",
exc_info=True,
task_id=task.task_id,
step_id=step.step_id,
task=task,

View File

@@ -41,7 +41,7 @@ class AsyncAWSClient:
error_code = e.response["Error"]["Code"] # type: ignore
except Exception:
error_code = "failed-to-get-error-code"
LOG.exception("Failed to get secret.", secret_name=secret_name, error_code=error_code, exc_info=True)
LOG.exception("Failed to get secret.", secret_name=secret_name, error_code=error_code)
return None
@execute_with_async_client(client_type=AWSClientType.S3)

View File

@@ -165,10 +165,10 @@ class AgentDB:
await session.refresh(new_artifact)
return convert_to_artifact(new_artifact, self.debug_enabled)
except SQLAlchemyError:
LOG.exception("SQLAlchemyError", exc_info=True)
LOG.exception("SQLAlchemyError")
raise
except Exception:
LOG.exception("UnexpectedError", exc_info=True)
LOG.exception("UnexpectedError")
raise
async def get_task(self, task_id: str, organization_id: str | None = None) -> Task | None:
@@ -580,10 +580,10 @@ class AgentDB:
else:
return None
except SQLAlchemyError:
LOG.exception("SQLAlchemyError", exc_info=True)
LOG.exception("SQLAlchemyError")
raise
except Exception:
LOG.exception("UnexpectedError", exc_info=True)
LOG.exception("UnexpectedError")
raise
async def get_artifact(
@@ -662,10 +662,10 @@ class AgentDB:
return artifacts[0]
return None
except SQLAlchemyError:
LOG.exception("SQLAlchemyError", exc_info=True)
LOG.exception("SQLAlchemyError")
raise
except Exception:
LOG.exception("UnexpectedError", exc_info=True)
LOG.exception("UnexpectedError")
raise
async def get_latest_n_artifacts(
@@ -693,10 +693,10 @@ class AgentDB:
return [convert_to_artifact(artifact, self.debug_enabled) for artifact in artifacts]
return None
except SQLAlchemyError:
LOG.exception("SQLAlchemyError", exc_info=True)
LOG.exception("SQLAlchemyError")
raise
except Exception:
LOG.exception("UnexpectedError", exc_info=True)
LOG.exception("UnexpectedError")
raise
async def get_latest_task_by_workflow_id(

View File

@@ -85,7 +85,6 @@ class Block(BaseModel, abc.ABC):
except Exception:
LOG.exception(
"Block execution failed",
exc_info=True,
workflow_run_id=workflow_run_id,
block_label=self.label,
block_type=self.block_type,
@@ -657,7 +656,7 @@ class UploadToS3Block(Block):
uri=self._get_s3_uri(workflow_run_id, self.path), file_path=self.path
)
except Exception as e:
LOG.exception("UploadToS3Block: Failed to upload file to S3", file_path=self.path, exc_info=True)
LOG.exception("UploadToS3Block: Failed to upload file to S3", file_path=self.path)
raise e
LOG.info("UploadToS3Block: File(s) uploaded to S3", file_path=self.path)

View File

@@ -192,7 +192,6 @@ class WorkflowService:
LOG.exception(
f"Error while executing workflow run {workflow_run.workflow_run_id}",
workflow_run_id=workflow_run.workflow_run_id,
exc_info=True,
)
await self.mark_workflow_run_as_failed(workflow_run_id=workflow_run.workflow_run_id)
raise e