vodorod/Dorod-Sky
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix scrolling makes element invisible (#881)

Browse Source
This commit is contained in:
LawyZheng
2024-09-25 09:46:37 +08:00
committed by GitHub
parent 48675f2024
commit 9cd925befa
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
skyvern/webeye/scraper/domUtils.js
View File

@@ -248,12 +248,16 @@ function isElementVisible(element) {
return false; return false;
} }
// if the center point of the element is not in the page, we tag it as an interactable element // if the center point of the element is not in the page, we tag it as an non-interactable element
const center_x = (rect.left + rect.width) / 2; // FIXME: sometimes there could be an overflow element blocking the default scrolling, making Y coordinate be wrong. So we currently only check for X
const center_y = (rect.top + rect.height) / 2; const center_x = (rect.left + rect.width) / 2 + window.scrollX;
if (center_x < 0 || center_y < 0) { if (center_x < 0) {
return false; return false;
} }
// const center_y = (rect.top + rect.height) / 2 + window.scrollY;
// if (center_x < 0 || center_y < 0) {
// return false;
// }
return true; return true;
} }