vodorod/Dorod-Sky
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

makmisi/dont close browser (#1780)

Browse Source
This commit is contained in:
Shuchang Zheng
2025-02-18 00:27:21 +08:00
committed by GitHub
parent b571c112c3
commit 99e6b0d2ca
2 changed files with 14 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
skyvern/forge/agent.py
View File

@@ -317,7 +317,7 @@ class ForgeAgent:
api_key=api_key, api_key=api_key,
need_call_webhook=True, need_call_webhook=True,
browser_session_id=browser_session_id, browser_session_id=browser_session_id,
close_browser_on_completion=close_browser_on_completion, close_browser_on_completion=close_browser_on_completion and browser_session_id is None,
) )
return step, None, None return step, None, None
@@ -373,7 +373,7 @@ class ForgeAgent:
last_step=step, last_step=step,
api_key=api_key, api_key=api_key,
need_call_webhook=True, need_call_webhook=True,
close_browser_on_completion=close_browser_on_completion, close_browser_on_completion=close_browser_on_completion and browser_session_id is None,
browser_session_id=browser_session_id, browser_session_id=browser_session_id,
) )
return step, detailed_output, None return step, detailed_output, None
@@ -445,7 +445,7 @@ class ForgeAgent:
task=completed_task, task=completed_task,
last_step=last_step, last_step=last_step,
api_key=api_key, api_key=api_key,
close_browser_on_completion=close_browser_on_completion, close_browser_on_completion=close_browser_on_completion and browser_session_id is None,
browser_session_id=browser_session_id, browser_session_id=browser_session_id,
) )
return last_step, detailed_output, None return last_step, detailed_output, None
@@ -462,7 +462,7 @@ class ForgeAgent:
task=task, task=task,
last_step=step, last_step=step,
api_key=api_key, api_key=api_key,
close_browser_on_completion=close_browser_on_completion, close_browser_on_completion=close_browser_on_completion and browser_session_id is None,
browser_session_id=browser_session_id, browser_session_id=browser_session_id,
) )
return step, detailed_output, None return step, detailed_output, None
@@ -485,7 +485,7 @@ class ForgeAgent:
task=task, task=task,
last_step=last_step, last_step=last_step,
api_key=api_key, api_key=api_key,
close_browser_on_completion=close_browser_on_completion, close_browser_on_completion=close_browser_on_completion and browser_session_id is None,
browser_session_id=browser_session_id, browser_session_id=browser_session_id,
) )
return last_step, detailed_output, None return last_step, detailed_output, None
@@ -558,7 +558,7 @@ class ForgeAgent:
task=task, task=task,
last_step=step, last_step=step,
api_key=api_key, api_key=api_key,
close_browser_on_completion=close_browser_on_completion, close_browser_on_completion=browser_session_id is None,
browser_session_id=browser_session_id, browser_session_id=browser_session_id,
) )
return step, detailed_output, None return step, detailed_output, None
@@ -575,7 +575,7 @@ class ForgeAgent:
task=task, task=task,
last_step=step, last_step=step,
api_key=api_key, api_key=api_key,
close_browser_on_completion=close_browser_on_completion, close_browser_on_completion=close_browser_on_completion and browser_session_id is None,
browser_session_id=browser_session_id, browser_session_id=browser_session_id,
) )
else: else:
@@ -610,7 +610,7 @@ class ForgeAgent:
task=task, task=task,
last_step=step, last_step=step,
api_key=api_key, api_key=api_key,
close_browser_on_completion=close_browser_on_completion, close_browser_on_completion=close_browser_on_completion and browser_session_id is None,
need_final_screenshot=False, need_final_screenshot=False,
browser_session_id=browser_session_id, browser_session_id=browser_session_id,
) )
@@ -632,6 +632,7 @@ class ForgeAgent:
api_key=api_key, api_key=api_key,
need_call_webhook=False, need_call_webhook=False,
browser_session_id=browser_session_id, browser_session_id=browser_session_id,
close_browser_on_completion=close_browser_on_completion and browser_session_id is None,
) )
return step, detailed_output, None return step, detailed_output, None
except InvalidTaskStatusTransition: except InvalidTaskStatusTransition:
@@ -647,7 +648,7 @@ class ForgeAgent:
api_key=api_key, api_key=api_key,
need_call_webhook=False, need_call_webhook=False,
browser_session_id=browser_session_id, browser_session_id=browser_session_id,
close_browser_on_completion=close_browser_on_completion, close_browser_on_completion=close_browser_on_completion and browser_session_id is None,
) )
return step, detailed_output, None return step, detailed_output, None
except (UnsupportedActionType, UnsupportedTaskType, FailedToParseActionInstruction) as e: except (UnsupportedActionType, UnsupportedTaskType, FailedToParseActionInstruction) as e:
@@ -665,7 +666,7 @@ class ForgeAgent:
api_key=api_key, api_key=api_key,
need_call_webhook=False, need_call_webhook=False,
browser_session_id=browser_session_id, browser_session_id=browser_session_id,
close_browser_on_completion=close_browser_on_completion, close_browser_on_completion=close_browser_on_completion and browser_session_id is None,
) )
return step, detailed_output, None return step, detailed_output, None
@@ -686,7 +687,7 @@ class ForgeAgent:
task=task, task=task,
last_step=step, last_step=step,
api_key=api_key, api_key=api_key,
close_browser_on_completion=close_browser_on_completion, close_browser_on_completion=close_browser_on_completion and browser_session_id is None,
browser_session_id=browser_session_id, browser_session_id=browser_session_id,
) )
else: else:

4
skyvern/forge/sdk/workflow/service.py
View File

@@ -1084,8 +1084,8 @@ class WorkflowService:
browser_state = await app.BROWSER_MANAGER.cleanup_for_workflow_run( browser_state = await app.BROWSER_MANAGER.cleanup_for_workflow_run(
workflow_run.workflow_run_id, workflow_run.workflow_run_id,
all_workflow_task_ids, all_workflow_task_ids,
close_browser_on_completion, close_browser_on_completion=close_browser_on_completion and browser_session_id is None,
browser_session_id, browser_session_id=browser_session_id,
organization_id=workflow_run.organization_id, organization_id=workflow_run.organization_id,
) )
if browser_state: if browser_state: