From 8d0b0442708e38e077a02c4c62dd693b39533f8c Mon Sep 17 00:00:00 2001 From: Kerem Yilmaz Date: Mon, 16 Sep 2024 08:39:27 -0700 Subject: [PATCH] fix angular select bug (#831) --- skyvern/webeye/scraper/domUtils.js | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/skyvern/webeye/scraper/domUtils.js b/skyvern/webeye/scraper/domUtils.js index 9a70bffb..bc60f77c 100644 --- a/skyvern/webeye/scraper/domUtils.js +++ b/skyvern/webeye/scraper/domUtils.js @@ -418,8 +418,10 @@ function isInteractable(element) { return true; } - if (tagName === "div" && hasAngularClickBinding(element)) { - return true; + if (tagName === "div" || tagName === "span") { + if (hasAngularClickBinding(element)) { + return true; + } } // support listbox and options underneath it @@ -562,12 +564,7 @@ const isAngularDropdown = (element) => { } const tagName = element.tagName.toLowerCase(); - // TODO: some angular might use to trigger dropdown menu - // if (tagName === "span") { - // ... - // } - - if (tagName === "input") { + if (tagName === "input" || tagName === "span") { const ariaLabel = element.hasAttribute("aria-label") ? element.getAttribute("aria-label").toLowerCase() : "";