laminar fix attempt (#3742)

skyvern/forge/sdk/trace/__init__.py

@@ -1,9 +1,11 @@
 from functools import wraps
 from typing import Any, Awaitable, Callable, ParamSpec, TypeVar
 
+from skyvern.forge import app
 from skyvern.forge.sdk.core import skyvern_context
 from skyvern.forge.sdk.settings_manager import SettingsManager
 from skyvern.forge.sdk.trace.base import BaseTrace, NoOpTrace
+from skyvern.forge.sdk.trace.experiment_utils import collect_experiment_metadata_safely
 
 P = ParamSpec("P")
 R = TypeVar("R")
@@ -37,6 +39,11 @@ class TraceManager:
                     new_metadata["organization_name"] = context.organization_name
                     user_id = context.run_id
 
+                    # Collect experiment metadata and include it in the span metadata
+                    experiment_metadata = await collect_experiment_metadata_safely(app.EXPERIMENTATION_PROVIDER)
+                    if experiment_metadata:
+                        new_metadata.update(experiment_metadata)
+
                 new_tags: list[str] = tags or []
                 new_tags.append(SettingsManager.get_settings().ENV)
 

skyvern/forge/sdk/trace/lmnr.py

@@ -42,7 +42,7 @@ class LaminarTrace(BaseTrace):
 
             # Map status to appropriate tag
             status_tag_map = {
-                "completed": "COMPLETION",
+                "completed": "COMPLETED",
                 "failed": "FAILURE",
                 "timed_out": "TIMEOUT",
                 "canceled": "CANCELED",

skyvern/forge/sdk/workflow/service.py

@@ -41,7 +41,6 @@ from skyvern.forge.sdk.schemas.organizations import Organization
 from skyvern.forge.sdk.schemas.tasks import Task
 from skyvern.forge.sdk.schemas.workflow_runs import WorkflowRunBlock, WorkflowRunTimeline, WorkflowRunTimelineType
 from skyvern.forge.sdk.trace import TraceManager
-from skyvern.forge.sdk.trace.experiment_utils import collect_experiment_metadata_safely
 from skyvern.forge.sdk.workflow.exceptions import (
     ContextParameterSourceNotDefined,
     InvalidWaitBlockTime,
@@ -347,11 +346,6 @@ class WorkflowService:
         """Execute a workflow."""
         organization_id = organization.organization_id
 
-        # Collect and add experiment metadata to the trace
-        experiment_metadata = await collect_experiment_metadata_safely(app.EXPERIMENTATION_PROVIDER)
-        if experiment_metadata:
-            TraceManager.add_experiment_metadata(experiment_metadata)
-
         LOG.info(
             "Executing workflow",
             workflow_run_id=workflow_run_id,