Fix tooltip weird behavior in editable titles (#1268)

This commit is contained in:
Shuchang Zheng
2024-11-26 08:49:25 -08:00
committed by GitHub
parent 38c42b6b48
commit 80f2d5ae96

View File

@@ -25,11 +25,11 @@ function EditableNodeTitle({
}: Props) { }: Props) {
const [editing, setEditing] = useState(false); const [editing, setEditing] = useState(false);
if (!editing) {
return ( return (
<TooltipProvider> <TooltipProvider>
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
{!editing ? (
<h1 <h1
className={cn("cursor-text", titleClassName)} className={cn("cursor-text", titleClassName)}
onClick={() => { onClick={() => {
@@ -38,7 +38,14 @@ function EditableNodeTitle({
> >
{value} {value}
</h1> </h1>
) : ( </TooltipTrigger>
<TooltipContent>Click to edit</TooltipContent>
</Tooltip>
</TooltipProvider>
);
}
return (
<HorizontallyResizingInput <HorizontallyResizingInput
disabled={!editable} disabled={!editable}
size={1} size={1}
@@ -68,11 +75,6 @@ function EditableNodeTitle({
}} }}
defaultValue={value} defaultValue={value}
/> />
)}
</TooltipTrigger>
<TooltipContent>Click to edit</TooltipContent>
</Tooltip>
</TooltipProvider>
); );
} }