removing laminar (#3858)

pyproject.toml

@@ -66,7 +66,6 @@ dependencies = [
     "lark>=1.2.2,<2",
     "libcst>=1.8.2,<2",
     "curlparser>=0.1.0,<0.2",
-    "lmnr[all]>=0.7.0,<0.8",
     "openpyxl>=3.1.5,<4",
     "pandas>=2.3.1,<3",
     "azure-identity>=1.24.0,<2",

skyvern/config.py

@@ -361,7 +361,7 @@ class Settings(BaseSettings):
 
     # Trace settings
     TRACE_ENABLED: bool = False
-    TRACE_PROVIDER: str = "lmnr"
+    TRACE_PROVIDER: str = ""
     TRACE_PROVIDER_HOST: str | None = None
     TRACE_PROVIDER_API_KEY: str = "fillmein"
 

skyvern/forge/agent.py

@@ -2391,7 +2391,7 @@ class ForgeAgent:
         # log the task status as an event
         analytics.capture("skyvern-oss-agent-task-status", {"status": task.status})
 
-        # Add task completion tag to Laminar trace
+        # Add task completion tag to trace
         TraceManager.add_task_completion_tag(task.status.value)
         if need_final_screenshot:
             # Take one last screenshot and create an artifact before closing the browser to see the final state

skyvern/forge/app.py

@@ -19,8 +19,6 @@ from skyvern.forge.sdk.services.credential.azure_credential_vault_service import
 from skyvern.forge.sdk.services.credential.bitwarden_credential_service import BitwardenCredentialVaultService
 from skyvern.forge.sdk.services.credential.credential_vault_service import CredentialVaultService
 from skyvern.forge.sdk.settings_manager import SettingsManager
-from skyvern.forge.sdk.trace import TraceManager
-from skyvern.forge.sdk.trace.lmnr import LaminarTrace
 from skyvern.forge.sdk.workflow.context_manager import WorkflowContextManager
 from skyvern.forge.sdk.workflow.service import WorkflowService
 from skyvern.webeye.browser_manager import BrowserManager
@@ -136,7 +134,3 @@ api_app_startup_event: Callable[[], Awaitable[None]] | None = None
 api_app_shutdown_event: Callable[[], Awaitable[None]] | None = None
 
 agent = ForgeAgent()
-
-if SettingsManager.get_settings().TRACE_ENABLED:
-    if SettingsManager.get_settings().TRACE_PROVIDER == "lmnr":
-        TraceManager.set_trace_provider(LaminarTrace(api_key=SettingsManager.get_settings().TRACE_PROVIDER_API_KEY))

skyvern/forge/sdk/trace/experiment_utils.py

@@ -1,4 +1,4 @@
-"""Utilities for collecting and formatting experiment data for Laminar tracing."""
+"""Utilities for collecting and formatting experiment data for tracing."""
 
 from typing import TYPE_CHECKING, Any
 
@@ -44,7 +44,7 @@ async def collect_experiment_metadata(
         experimentation_provider: The experimentation provider to use for fetching experiment data.
 
     Returns:
-        Dictionary containing experiment data that can be added to Laminar traces.
+        Dictionary containing experiment data that can be added to traces.
     """
     # Get the current context
     context = skyvern_context.current()

skyvern/forge/sdk/workflow/service.py

@@ -1465,7 +1465,7 @@ class WorkflowService:
             workflow_status="completed",
         )
 
-        # Add workflow completion tag to Laminar trace
+        # Add workflow completion tag to trace
         TraceManager.add_task_completion_tag(WorkflowRunStatus.completed)
 
         return await self._update_workflow_run_status(
@@ -1487,7 +1487,7 @@ class WorkflowService:
             failure_reason=failure_reason,
         )
 
-        # Add workflow failure tag to Laminar trace
+        # Add workflow failure tag to trace
         TraceManager.add_task_completion_tag(WorkflowRunStatus.failed)
 
         return await self._update_workflow_run_status(
@@ -1523,7 +1523,7 @@ class WorkflowService:
             failure_reason=failure_reason,
         )
 
-        # Add workflow terminated tag to Laminar trace
+        # Add workflow terminated tag to trace
         TraceManager.add_task_completion_tag(WorkflowRunStatus.terminated)
 
         return await self._update_workflow_run_status(
@@ -1540,7 +1540,7 @@ class WorkflowService:
             workflow_status="canceled",
         )
 
-        # Add workflow canceled tag to Laminar trace
+        # Add workflow canceled tag to trace
         TraceManager.add_task_completion_tag(WorkflowRunStatus.canceled)
 
         return await self._update_workflow_run_status(
@@ -1561,7 +1561,7 @@ class WorkflowService:
             workflow_status="timed_out",
         )
 
-        # Add workflow timed out tag to Laminar trace
+        # Add workflow timed out tag to trace
         TraceManager.add_task_completion_tag(WorkflowRunStatus.timed_out)
 
         return await self._update_workflow_run_status(

skyvern/services/task_v2_service.py

@@ -1516,7 +1516,7 @@ async def mark_task_v2_as_failed(
             workflow_run_id, failure_reason=failure_reason or "Skyvern task 2.0 failed"
         )
 
-    # Add task failure tag to Laminar trace
+    # Add task failure tag to trace
     TraceManager.add_task_completion_tag("failed")
 
     await send_task_v2_webhook(task_v2)
@@ -1540,7 +1540,7 @@ async def mark_task_v2_as_completed(
     if workflow_run_id:
         await app.WORKFLOW_SERVICE.mark_workflow_run_as_completed(workflow_run_id)
 
-    # Add task completion tag to Laminar trace
+    # Add task completion tag to trace
     TraceManager.add_task_completion_tag("completed")
 
     await send_task_v2_webhook(task_v2)
@@ -1560,7 +1560,7 @@ async def mark_task_v2_as_canceled(
     if workflow_run_id:
         await app.WORKFLOW_SERVICE.mark_workflow_run_as_canceled(workflow_run_id)
 
-    # Add task canceled tag to Laminar trace
+    # Add task canceled tag to trace
     TraceManager.add_task_completion_tag("canceled")
 
     await send_task_v2_webhook(task_v2)
@@ -1581,7 +1581,7 @@ async def mark_task_v2_as_terminated(
     if workflow_run_id:
         await app.WORKFLOW_SERVICE.mark_workflow_run_as_terminated(workflow_run_id, failure_reason)
 
-    # Add task terminated tag to Laminar trace
+    # Add task terminated tag to trace
     TraceManager.add_task_completion_tag("terminated")
 
     await send_task_v2_webhook(task_v2)
@@ -1602,7 +1602,7 @@ async def mark_task_v2_as_timed_out(
     if workflow_run_id:
         await app.WORKFLOW_SERVICE.mark_workflow_run_as_timed_out(workflow_run_id, failure_reason)
 
-    # Add task timed out tag to Laminar trace
+    # Add task timed out tag to trace
     TraceManager.add_task_completion_tag("timed_out")
 
     await send_task_v2_webhook(task_v2)