Remove code generation deletion confirmation prompt (#4635)
Co-authored-by: Suchintan Singh <suchintan@skyvern.com>
This commit is contained in:
@@ -356,8 +356,6 @@ function Workspace({
|
||||
|
||||
await saveWorkflow.mutateAsync();
|
||||
|
||||
workflowChangesStore.setSaidOkToCodeCacheDeletion(false);
|
||||
|
||||
queryClient.invalidateQueries({
|
||||
queryKey: ["cache-key-values", workflowPermanentId, cacheKey],
|
||||
});
|
||||
@@ -1113,40 +1111,6 @@ function Workspace({
|
||||
</DialogContent>
|
||||
</Dialog>
|
||||
|
||||
{/* confirm code cache deletion dialog */}
|
||||
<Dialog
|
||||
open={workflowChangesStore.showConfirmCodeCacheDeletion}
|
||||
onOpenChange={(open) => {
|
||||
!open && workflowChangesStore.setShowConfirmCodeCacheDeletion(false);
|
||||
!open && workflowChangesStore.setSaidOkToCodeCacheDeletion(false);
|
||||
}}
|
||||
>
|
||||
<DialogContent>
|
||||
<DialogHeader>
|
||||
<DialogTitle>Are you sure?</DialogTitle>
|
||||
<DialogDescription>
|
||||
Saving will delete cached code, and Skyvern will re-generate it in
|
||||
the next run. Proceed?
|
||||
</DialogDescription>
|
||||
</DialogHeader>
|
||||
<DialogFooter>
|
||||
<DialogClose asChild>
|
||||
<Button variant="secondary">Cancel</Button>
|
||||
</DialogClose>
|
||||
<Button
|
||||
variant="default"
|
||||
onClick={async () => {
|
||||
workflowChangesStore.setSaidOkToCodeCacheDeletion(true);
|
||||
await handleOnSave();
|
||||
workflowChangesStore.setShowConfirmCodeCacheDeletion(false);
|
||||
}}
|
||||
>
|
||||
Yes
|
||||
</Button>
|
||||
</DialogFooter>
|
||||
</DialogContent>
|
||||
</Dialog>
|
||||
|
||||
{/* cache key value delete dialog */}
|
||||
<Dialog
|
||||
open={openConfirmCacheKeyValueDeleteDialogue}
|
||||
|
||||
@@ -29,14 +29,10 @@ type WorkflowHasChangesStore = {
|
||||
getSaveData: () => SaveData | null;
|
||||
hasChanges: boolean;
|
||||
saveIsPending: boolean;
|
||||
saidOkToCodeCacheDeletion: boolean;
|
||||
showConfirmCodeCacheDeletion: boolean;
|
||||
isInternalUpdate: boolean;
|
||||
setGetSaveData: (getSaveData: () => SaveData) => void;
|
||||
setHasChanges: (hasChanges: boolean) => void;
|
||||
setSaveIsPending: (isPending: boolean) => void;
|
||||
setSaidOkToCodeCacheDeletion: (saidOkToCodeCacheDeletion: boolean) => void;
|
||||
setShowConfirmCodeCacheDeletion: (show: boolean) => void;
|
||||
setIsInternalUpdate: (isInternalUpdate: boolean) => void;
|
||||
};
|
||||
|
||||
@@ -48,8 +44,6 @@ const useWorkflowHasChangesStore = create<WorkflowHasChangesStore>((set) => {
|
||||
return {
|
||||
hasChanges: false,
|
||||
saveIsPending: false,
|
||||
saidOkToCodeCacheDeletion: false,
|
||||
showConfirmCodeCacheDeletion: false,
|
||||
isInternalUpdate: false,
|
||||
getSaveData: () => null,
|
||||
setGetSaveData: (getSaveData: () => SaveData) => {
|
||||
@@ -61,12 +55,6 @@ const useWorkflowHasChangesStore = create<WorkflowHasChangesStore>((set) => {
|
||||
setSaveIsPending: (isPending: boolean) => {
|
||||
set({ saveIsPending: isPending });
|
||||
},
|
||||
setSaidOkToCodeCacheDeletion: (saidOkToCodeCacheDeletion: boolean) => {
|
||||
set({ saidOkToCodeCacheDeletion });
|
||||
},
|
||||
setShowConfirmCodeCacheDeletion: (show: boolean) => {
|
||||
set({ showConfirmCodeCacheDeletion: show });
|
||||
},
|
||||
setIsInternalUpdate: (isInternalUpdate: boolean) => {
|
||||
set({ isInternalUpdate });
|
||||
},
|
||||
@@ -76,13 +64,8 @@ const useWorkflowHasChangesStore = create<WorkflowHasChangesStore>((set) => {
|
||||
const useWorkflowSave = (opts?: WorkflowSaveOpts) => {
|
||||
const credentialGetter = useCredentialGetter();
|
||||
const queryClient = useQueryClient();
|
||||
const {
|
||||
getSaveData,
|
||||
saidOkToCodeCacheDeletion,
|
||||
setHasChanges,
|
||||
setSaveIsPending,
|
||||
setShowConfirmCodeCacheDeletion,
|
||||
} = useWorkflowHasChangesStore();
|
||||
const { getSaveData, setHasChanges, setSaveIsPending } =
|
||||
useWorkflowHasChangesStore();
|
||||
|
||||
const saveWorkflowMutation = useMutation({
|
||||
mutationFn: async () => {
|
||||
@@ -166,11 +149,6 @@ const useWorkflowSave = (opts?: WorkflowSaveOpts) => {
|
||||
headers: {
|
||||
"Content-Type": "text/plain",
|
||||
},
|
||||
params: {
|
||||
delete_code_cache_is_ok: saidOkToCodeCacheDeletion
|
||||
? "true"
|
||||
: "false",
|
||||
},
|
||||
},
|
||||
);
|
||||
},
|
||||
@@ -204,14 +182,6 @@ const useWorkflowSave = (opts?: WorkflowSaveOpts) => {
|
||||
onError: (error: AxiosError) => {
|
||||
const detail = (error.response?.data as { detail?: string })?.detail;
|
||||
|
||||
if (
|
||||
detail &&
|
||||
detail.startsWith("No confirmation for code cache deletion")
|
||||
) {
|
||||
setShowConfirmCodeCacheDeletion(true);
|
||||
return;
|
||||
}
|
||||
|
||||
toast({
|
||||
title: "Error",
|
||||
description: detail ? detail : error.message,
|
||||
|
||||
Reference in New Issue
Block a user