vodorod/Dorod-Sky
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

make task failure log more consistent with 'marking task as failed' (#782)

Browse Source
This commit is contained in:
Shuchang Zheng
2024-09-07 16:48:50 -07:00
committed by GitHub
parent bfce9f2279
commit 433e30e84f
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
skyvern/forge/agent.py
View File

@@ -382,7 +382,7 @@ class ForgeAgent:
raise raise
except StepTerminationError as e: except StepTerminationError as e:
LOG.warning( LOG.warning(
"Step cannot be executed. Task failed.", "Step cannot be executed, marking task as failed",
task_id=task.task_id, task_id=task.task_id,
step_id=step.step_id, step_id=step.step_id,
exc_info=True, exc_info=True,
@@ -442,7 +442,7 @@ class ForgeAgent:
return step, detailed_output, None return step, detailed_output, None
except Exception as e: except Exception as e:
LOG.exception( LOG.exception(
"Got an unexpected exception in step, fail the task", "Got an unexpected exception in step, marking task as failed",
task_id=task.task_id, task_id=task.task_id,
step_id=step.step_id, step_id=step.step_id,
) )

8
skyvern/forge/sdk/routes/streaming.py
View File

@@ -104,12 +104,12 @@ async def task_stream(
except ValidationError as e: except ValidationError as e:
await websocket.send_text(f"Invalid data: {e}") await websocket.send_text(f"Invalid data: {e}")
except WebSocketDisconnect: except WebSocketDisconnect:
LOG.info("WebSocket connection closed") LOG.info("WebSocket connection closed", task_id=task_id, organization_id=organization_id)
except ConnectionClosedOK: except ConnectionClosedOK:
LOG.info("ConnectionClosedOK error while streaming", exc_info=True) LOG.info("ConnectionClosedOK error while streaming", task_id=task_id, organization_id=organization_id)
return return
except Exception: except Exception:
LOG.warning("Error while streaming", exc_info=True) LOG.warning("Error while streaming", task_id=task_id, organization_id=organization_id)
return return
LOG.info("WebSocket connection closed successfully") LOG.info("WebSocket connection closed successfully", task_id=task_id, organization_id=organization_id)
return return