vodorod/Dorod-Sky
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

shu/fix cdp connect with browser path (#2057)

Browse Source
This commit is contained in:
Shuchang Zheng
2025-04-01 01:19:14 -04:00
committed by GitHub
parent c14086ea85
commit 3fc6e2532f
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
skyvern/agent/agent.py
View File

@@ -44,10 +44,10 @@ class SkyvernAgent:
# TODO validate browser_path # TODO validate browser_path
# Supported Browsers: Google Chrome, Brave Browser, Microsoft Edge, Firefox # Supported Browsers: Google Chrome, Brave Browser, Microsoft Edge, Firefox
if "Chrome" in browser_path or "Brave" in browser_path or "Edge" in browser_path: if "Chrome" in browser_path or "Brave" in browser_path or "Edge" in browser_path:
result = subprocess.run( self.browser_process = subprocess.Popen(
["/Applications/Google Chrome.app/Contents/MacOS/Google Chrome", "--remote-debugging-port=9222"] [browser_path, "--remote-debugging-port=9222"], stdout=subprocess.PIPE, stderr=subprocess.PIPE
) )
if result.returncode != 0: if self.browser_process.poll() is not None:
raise Exception(f"Failed to open browser. browser_path: {browser_path}") raise Exception(f"Failed to open browser. browser_path: {browser_path}")
self.cdp_url = "http://127.0.0.1:9222" self.cdp_url = "http://127.0.0.1:9222"

8
skyvern/webeye/browser_factory.py
View File

@@ -417,7 +417,13 @@ class BrowserState:
pages = self.browser_context.pages pages = self.browser_context.pages
for page in pages: for page in pages:
if page != cur_page: if page != cur_page:
await page.close() try:
async with asyncio.timeout(2):
await page.close()
except asyncio.TimeoutError:
LOG.warning("Timeout to close the page. Skip closing the page", url=page.url)
except Exception:
LOG.exception("Error while closing the page", url=page.url)
async def check_and_fix_state( async def check_and_fix_state(
self, self,