rename variable (#2865)

skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx

@@ -322,8 +322,7 @@ function FlowRenderer({
         webhook_callback_url: data.settings.webhookCallbackUrl,
         persist_browser_session: data.settings.persistBrowserSession,
         model: data.settings.model,
-        max_screenshot_scrolling_times:
-          data.settings.maxScreenshotScrollingTimes,
+        max_screenshot_scrolls: data.settings.maxScreenshotScrolls,
         totp_verification_url: workflow.totp_verification_url,
         extra_http_headers: extraHttpHeaders,
         workflow_definition: {

skyvern-frontend/src/routes/workflows/editor/WorkflowEditor.tsx

@@ -60,7 +60,7 @@ function WorkflowEditor() {
     proxyLocation: workflow.proxy_location,
     webhookCallbackUrl: workflow.webhook_callback_url,
     model: workflow.model,
-    maxScreenshotScrollingTimes: workflow.max_screenshot_scrolling_times,
+    maxScreenshotScrolls: workflow.max_screenshot_scrolls,
     extraHttpHeaders: workflow.extra_http_headers
       ? JSON.stringify(workflow.extra_http_headers)
       : null,

skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/StartNode.tsx

@@ -20,7 +20,7 @@ import { Separator } from "@/components/ui/separator";
 import { ModelsResponse } from "@/api/types";
 import { ModelSelector } from "@/components/ModelSelector";
 import { WorkflowModel } from "@/routes/workflows/types/workflowTypes";
-import { MAX_SCREENSHOT_SCROLLING_TIMES_DEFAULT } from "../Taskv2Node/types";
+import { MAX_SCREENSHOT_SCROLLS_DEFAULT } from "../Taskv2Node/types";
 import { KeyValueInput } from "@/components/KeyValueInput";
 
 function StartNode({ id, data }: NodeProps<StartNode>) {
@@ -53,8 +53,8 @@ function StartNode({ id, data }: NodeProps<StartNode>) {
       ? data.persistBrowserSession
       : false,
     model: data.withWorkflowSettings ? data.model : workflowModel,
-    maxScreenshotScrollingTimes: data.withWorkflowSettings
-      ? data.maxScreenshotScrollingTimes
+    maxScreenshotScrolls: data.withWorkflowSettings
+      ? data.maxScreenshotScrolls
       : null,
     extraHttpHeaders: data.withWorkflowSettings ? data.extraHttpHeaders : null,
   });
@@ -151,21 +151,21 @@ function StartNode({ id, data }: NodeProps<StartNode>) {
                     </div>
                     <div className="space-y-2">
                       <div className="flex items-center gap-2">
-                        <Label>Max Scrolling Screenshots</Label>
+                        <Label>Max Screenshot Scrolls</Label>
                         <HelpTooltip
-                          content={`The maximum number of times to scroll down the page to take merged screenshots after action. Default is ${MAX_SCREENSHOT_SCROLLING_TIMES_DEFAULT}. If it's set to 0, it will take the current viewport screenshot.`}
+                          content={`The maximum number of scrolls for the post action screenshot. Default is ${MAX_SCREENSHOT_SCROLLS_DEFAULT}. If it's set to 0, it will take the current viewport screenshot.`}
                         />
                       </div>
                       <Input
-                        value={inputs.maxScreenshotScrollingTimes ?? ""}
-                        placeholder={`Default: ${MAX_SCREENSHOT_SCROLLING_TIMES_DEFAULT}`}
+                        value={inputs.maxScreenshotScrolls ?? ""}
+                        placeholder={`Default: ${MAX_SCREENSHOT_SCROLLS_DEFAULT}`}
                         onChange={(event) => {
                           const value =
                             event.target.value === ""
                               ? null
                               : Number(event.target.value);
 
-                          handleChange("maxScreenshotScrollingTimes", value);
+                          handleChange("maxScreenshotScrolls", value);
                         }}
                       />
                     </div>

skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/types.ts

@@ -9,7 +9,7 @@ export type WorkflowStartNodeData = {
   proxyLocation: ProxyLocation;
   persistBrowserSession: boolean;
   model: WorkflowModel | null;
-  maxScreenshotScrollingTimes: number | null;
+  maxScreenshotScrolls: number | null;
   extraHttpHeaders: string | null;
   editable: boolean;
 };

skyvern-frontend/src/routes/workflows/editor/nodes/Taskv2Node/types.ts

@@ -2,7 +2,7 @@ import { Node } from "@xyflow/react";
 import { NodeBaseData } from "../types";
 
 export const MAX_STEPS_DEFAULT = 25;
-export const MAX_SCREENSHOT_SCROLLING_TIMES_DEFAULT = 3;
+export const MAX_SCREENSHOT_SCROLLS_DEFAULT = 3;
 
 export type Taskv2NodeData = NodeBaseData & {
   prompt: string;
@@ -10,7 +10,7 @@ export type Taskv2NodeData = NodeBaseData & {
   totpVerificationUrl: string | null;
   totpIdentifier: string | null;
   maxSteps: number | null;
-  maxScreenshotScrollingTimes: number | null;
+  maxScreenshotScrolls: number | null;
 };
 
 export type Taskv2Node = Node<Taskv2NodeData, "taskv2">;
@@ -25,7 +25,7 @@ export const taskv2NodeDefaultData: Taskv2NodeData = {
   totpVerificationUrl: null,
   maxSteps: MAX_STEPS_DEFAULT,
   model: null,
-  maxScreenshotScrollingTimes: null,
+  maxScreenshotScrolls: null,
 };
 
 export function isTaskV2Node(node: Node): node is Taskv2Node {

skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts

@@ -251,7 +251,7 @@ function convertToNode(
           maxSteps: block.max_steps,
           totpIdentifier: block.totp_identifier,
           totpVerificationUrl: block.totp_verification_url,
-          maxScreenshotScrollingTimes: null,
+          maxScreenshotScrolls: null,
         },
       };
     }
@@ -663,7 +663,7 @@ function getElements(
       proxyLocation: settings.proxyLocation ?? ProxyLocation.Residential,
       webhookCallbackUrl: settings.webhookCallbackUrl ?? "",
       model: settings.model,
-      maxScreenshotScrollingTimes: settings.maxScreenshotScrollingTimes,
+      maxScreenshotScrolls: settings.maxScreenshotScrolls,
       extraHttpHeaders: settings.extraHttpHeaders,
       editable,
     }),
@@ -1325,7 +1325,7 @@ function getWorkflowSettings(nodes: Array<AppNode>): WorkflowSettings {
     proxyLocation: ProxyLocation.Residential,
     webhookCallbackUrl: null,
     model: null,
-    maxScreenshotScrollingTimes: null,
+    maxScreenshotScrolls: null,
     extraHttpHeaders: null,
   };
   const startNodes = nodes.filter(isStartNode);
@@ -1342,7 +1342,7 @@ function getWorkflowSettings(nodes: Array<AppNode>): WorkflowSettings {
       proxyLocation: data.proxyLocation,
       webhookCallbackUrl: data.webhookCallbackUrl,
       model: data.model,
-      maxScreenshotScrollingTimes: data.maxScreenshotScrollingTimes,
+      maxScreenshotScrolls: data.maxScreenshotScrolls,
       extraHttpHeaders: data.extraHttpHeaders,
     };
   }
@@ -1999,7 +1999,7 @@ function convert(workflow: WorkflowApiResponse): WorkflowCreateYAMLRequest {
     persist_browser_session: workflow.persist_browser_session,
     model: workflow.model,
     totp_verification_url: workflow.totp_verification_url,
-    max_screenshot_scrolling_times: workflow.max_screenshot_scrolling_times,
+    max_screenshot_scrolls: workflow.max_screenshot_scrolls,
     extra_http_headers: workflow.extra_http_headers,
     workflow_definition: {
       parameters: convertParametersToParameterYAML(userParameters),