vodorod/Dorod-Sky
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Do not run complete verification for extract blocks or tasks without nav goal + disable complete verification for nav blocks in task v2 run (#1973)

Browse Source
This commit is contained in:
Shuchang Zheng
2025-03-19 18:16:55 -07:00
committed by GitHub
parent d211024adf
commit 32ad324af7
5 changed files with 32 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
skyvern/forge/sdk/workflow/models/block.py
View File

@@ -346,6 +346,7 @@ class BaseTaskBlock(Block):
totp_verification_url: str | None = None
totp_identifier: str | None = None
cache_actions: bool = False
complete_verification: bool = True
def get_all_parameters(
self,
@@ -601,6 +602,7 @@ class BaseTaskBlock(Block):
task_block=self,
browser_session_id=browser_session_id,
close_browser_on_completion=browser_session_id is None,
complete_verification=self.complete_verification,
)
except Exception as e:
# Make sure the task is marked as failed in the database before raising the exception

3
skyvern/forge/sdk/workflow/models/yaml.py
View File

@@ -141,6 +141,7 @@ class TaskBlockYAML(BlockYAML):
cache_actions: bool = False
complete_criterion: str | None = None
terminate_criterion: str | None = None
complete_verification: bool = True
class ForLoopBlockYAML(BlockYAML):
@@ -273,6 +274,7 @@ class NavigationBlockYAML(BlockYAML):
cache_actions: bool = False
complete_criterion: str | None = None
terminate_criterion: str | None = None
complete_verification: bool = True
class ExtractionBlockYAML(BlockYAML):
@@ -303,6 +305,7 @@ class LoginBlockYAML(BlockYAML):
cache_actions: bool = False
complete_criterion: str | None = None
terminate_criterion: str | None = None
complete_verification: bool = True
class WaitBlockYAML(BlockYAML):

8
skyvern/forge/sdk/workflow/service.py
View File

@@ -1595,6 +1595,7 @@ class WorkflowService:
cache_actions=block_yaml.cache_actions,
complete_criterion=block_yaml.complete_criterion,
terminate_criterion=block_yaml.terminate_criterion,
complete_verification=block_yaml.complete_verification,
)
elif block_yaml.block_type == BlockType.FOR_LOOP:
loop_blocks = [
@@ -1747,6 +1748,8 @@ class WorkflowService:
totp_verification_url=block_yaml.totp_verification_url,
totp_identifier=block_yaml.totp_identifier,
cache_actions=block_yaml.cache_actions,
# DO NOT run complete verification for action block
complete_verification=False,
max_steps_per_run=1,
)
@@ -1774,6 +1777,7 @@ class WorkflowService:
cache_actions=block_yaml.cache_actions,
complete_criterion=block_yaml.complete_criterion,
terminate_criterion=block_yaml.terminate_criterion,
complete_verification=block_yaml.complete_verification,
)
elif block_yaml.block_type == BlockType.EXTRACTION:
@@ -1794,6 +1798,7 @@ class WorkflowService:
max_retries=block_yaml.max_retries,
continue_on_failure=block_yaml.continue_on_failure,
cache_actions=block_yaml.cache_actions,
complete_verification=False,
)
elif block_yaml.block_type == BlockType.LOGIN:
@@ -1818,6 +1823,7 @@ class WorkflowService:
cache_actions=block_yaml.cache_actions,
complete_criterion=block_yaml.complete_criterion,
terminate_criterion=block_yaml.terminate_criterion,
complete_verification=block_yaml.complete_verification,
)
elif block_yaml.block_type == BlockType.WAIT:
@@ -1853,6 +1859,7 @@ class WorkflowService:
totp_identifier=block_yaml.totp_identifier,
cache_actions=block_yaml.cache_actions,
complete_on_download=True,
complete_verification=False,
)
elif block_yaml.block_type == BlockType.TaskV2:
return TaskV2Block(
@@ -1870,6 +1877,7 @@ class WorkflowService:
label=block_yaml.label,
url=block_yaml.url,
output_parameter=output_parameter,
complete_verification=False,
)
raise ValueError(f"Invalid block type {block_yaml.block_type}")