From 2608c02f7a592cc9decd293d7ab2c173a3b85222 Mon Sep 17 00:00:00 2001 From: Shuchang Zheng Date: Sat, 22 Nov 2025 21:07:34 -0800 Subject: [PATCH] lower default page loading time from 90 seconds to 60 seconds (#4076) --- skyvern/config.py | 2 +- skyvern/core/script_generations/script_skyvern_page.py | 2 +- skyvern/core/script_generations/skyvern_page.py | 2 +- skyvern/forge/agent.py | 2 +- skyvern/services/task_v2_service.py | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/skyvern/config.py b/skyvern/config.py index d5a38049..0181e1f1 100644 --- a/skyvern/config.py +++ b/skyvern/config.py @@ -41,7 +41,7 @@ class Settings(BaseSettings): TEMP_PATH: str = "./temp" BROWSER_ACTION_TIMEOUT_MS: int = 5000 BROWSER_SCREENSHOT_TIMEOUT_MS: int = 20000 - BROWSER_LOADING_TIMEOUT_MS: int = 90000 + BROWSER_LOADING_TIMEOUT_MS: int = 60000 BROWSER_SCRAPING_BUILDING_ELEMENT_TREE_TIMEOUT_MS: int = 60 * 1000 # 1 minute OPTION_LOADING_TIMEOUT_MS: int = 600000 MAX_STEPS_PER_RUN: int = 10 diff --git a/skyvern/core/script_generations/script_skyvern_page.py b/skyvern/core/script_generations/script_skyvern_page.py index 5aa0706e..bad2b0c8 100644 --- a/skyvern/core/script_generations/script_skyvern_page.py +++ b/skyvern/core/script_generations/script_skyvern_page.py @@ -402,7 +402,7 @@ class ScriptSkyvernPage(SkyvernPage): if context and context.script_mode: print(f"🌐 Navigating to: {url}") - timeout = kwargs.pop("timeout", settings.BROWSER_ACTION_TIMEOUT_MS) + timeout = kwargs.pop("timeout", settings.BROWSER_LOADING_TIMEOUT_MS) await self.page.goto(url, timeout=timeout, **kwargs) if context and context.script_mode: diff --git a/skyvern/core/script_generations/skyvern_page.py b/skyvern/core/script_generations/skyvern_page.py index 1e2fb5ab..74b0a9d4 100644 --- a/skyvern/core/script_generations/skyvern_page.py +++ b/skyvern/core/script_generations/skyvern_page.py @@ -93,7 +93,7 @@ class SkyvernPage(Page): return decorator async def goto(self, url: str, **kwargs: Any) -> None: - timeout = kwargs.pop("timeout", settings.BROWSER_ACTION_TIMEOUT_MS) + timeout = kwargs.pop("timeout", settings.BROWSER_LOADING_TIMEOUT_MS) await self.page.goto(url, timeout=timeout, **kwargs) ######### Public Interfaces ######### diff --git a/skyvern/forge/agent.py b/skyvern/forge/agent.py index 770b6f6c..e36a8cc2 100644 --- a/skyvern/forge/agent.py +++ b/skyvern/forge/agent.py @@ -443,7 +443,7 @@ class ForgeAgent: page = await browser_state.must_get_working_page() current_url = page.url if current_url.rstrip("/") != task.url.rstrip("/"): - await page.goto(task.url) + await page.goto(task.url, timeout=settings.BROWSER_LOADING_TIMEOUT_MS) step = await self.update_step( step, status=StepStatus.completed, is_last=True, output=AgentStepOutput(action_results=[]) ) diff --git a/skyvern/services/task_v2_service.py b/skyvern/services/task_v2_service.py index 130b00c4..4ec9f11a 100644 --- a/skyvern/services/task_v2_service.py +++ b/skyvern/services/task_v2_service.py @@ -657,7 +657,7 @@ async def run_task_v2_helper( # Page failed to load properly, fallback to Google if page: try: - await page.goto(fallback_url, timeout=15000) + await page.goto(fallback_url, timeout=settings.BROWSER_LOADING_TIMEOUT_MS) fallback_occurred = True except Exception: LOG.exception("Failed to load Google fallback", exc_info=True, url=url, current_url=current_url)