vodorod/Dorod-Sky
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix scraping edge case (#3186)

Browse Source
This commit is contained in:
LawyZheng
2025-08-14 15:04:15 +08:00
committed by GitHub
parent 65e9cb10e9
commit 2556d04e70
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
skyvern/webeye/scraper/domUtils.js
View File

@@ -115,7 +115,7 @@ class DomUtils {
} }
// add cache to optimize performance // add cache to optimize performance
static getVisibleClientRect(element, testChildren) { static getVisibleClientRect(element, testChildren = false) {
// check cache // check cache
const cacheKey = `${testChildren}`; const cacheKey = `${testChildren}`;
if (DomUtils.visibleClientRectCache.has(element)) { if (DomUtils.visibleClientRectCache.has(element)) {
@@ -128,7 +128,6 @@ class DomUtils {
// Note: this call will be expensive if we modify the DOM in between calls. // Note: this call will be expensive if we modify the DOM in between calls.
let clientRect; let clientRect;
if (testChildren == null) testChildren = false;
const clientRects = (() => { const clientRects = (() => {
const result = []; const result = [];
for (clientRect of element.getClientRects()) { for (clientRect of element.getClientRects()) {
@@ -1793,7 +1792,7 @@ function drawBoundingBoxes(elements) {
DomUtils.clearVisibleClientRectCache(); DomUtils.clearVisibleClientRectCache();
elements.forEach((element) => { elements.forEach((element) => {
const ele = getDOMElementBySkyvenElement(element); const ele = getDOMElementBySkyvenElement(element);
element.rect = DomUtils.getVisibleClientRect(ele, true); element.rect = ele ? DomUtils.getVisibleClientRect(ele, true) : null;
}); });
var groups = groupElementsVisually(elements); var groups = groupElementsVisually(elements);
var hintMarkers = createHintMarkersForGroups(groups); var hintMarkers = createHintMarkersForGroups(groups);