vodorod/Dorod-Sky
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Update screenshot logic (#281)

Browse Source
This commit is contained in:
Kerem Yilmaz
2024-05-08 02:48:45 -07:00
committed by GitHub
parent e5d094493e
commit 220f676dd9
1 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
skyvern/webeye/browser_factory.py
View File

@@ -219,20 +219,18 @@ class BrowserState:
await self.pw.stop() await self.pw.stop()
LOG.info("Playwright is stopped") LOG.info("Playwright is stopped")
async def take_screenshot(self, full_page: bool = False, file_path: str | None = None) -> bytes: @staticmethod
if not self.page: async def take_screenshot_from_page(page: Page, full_page: bool = False, file_path: str | None = None) -> bytes:
LOG.error("BrowserState has no page")
raise MissingBrowserStatePage()
try: try:
await self.page.wait_for_load_state(timeout=SettingsManager.get_settings().BROWSER_LOADING_TIMEOUT_MS) await page.wait_for_load_state(timeout=SettingsManager.get_settings().BROWSER_LOADING_TIMEOUT_MS)
LOG.info("Page is fully loaded, agent is about to take screenshots") LOG.info("Page is fully loaded, agent is about to take screenshots")
if file_path: if file_path:
return await self.page.screenshot( return await page.screenshot(
path=file_path, path=file_path,
full_page=full_page, full_page=full_page,
timeout=SettingsManager.get_settings().BROWSER_SCREENSHOT_TIMEOUT_MS, timeout=SettingsManager.get_settings().BROWSER_SCREENSHOT_TIMEOUT_MS,
) )
return await self.page.screenshot( return await page.screenshot(
full_page=full_page, full_page=full_page,
timeout=SettingsManager.get_settings().BROWSER_SCREENSHOT_TIMEOUT_MS, timeout=SettingsManager.get_settings().BROWSER_SCREENSHOT_TIMEOUT_MS,
animations="disabled", animations="disabled",
@@ -243,3 +241,10 @@ class BrowserState:
except Exception as e: except Exception as e:
LOG.exception(f"Unknown error while taking screenshot: {str(e)}") LOG.exception(f"Unknown error while taking screenshot: {str(e)}")
raise FailedToTakeScreenshot(error_message=str(e)) from e raise FailedToTakeScreenshot(error_message=str(e)) from e
async def take_screenshot(self, full_page: bool = False, file_path: str | None = None) -> bytes:
if not self.page:
LOG.error("BrowserState has no page")
raise MissingBrowserStatePage()
return await self.take_screenshot_from_page(self.page, full_page, file_path)