From 2166ab129b3b91def551ddcc54409c3cf9328268 Mon Sep 17 00:00:00 2001
From: Shuchang Zheng <wintonzheng0325@gmail.com>
Date: Wed, 29 Jan 2025 21:06:08 +0800
Subject: [PATCH] Remove TOTP URL from UI (#1674)

---
 .../routes/tasks/create/CreateNewTaskForm.tsx | 27 ------------------
 .../tasks/create/CreateNewTaskFormPage.tsx    |  3 --
 .../src/routes/tasks/create/SavedTaskForm.tsx | 28 -------------------
 .../routes/tasks/create/retry/RetryTask.tsx   |  1 -
 .../src/routes/tasks/create/taskFormTypes.ts  |  1 -
 .../editor/nodes/ActionNode/ActionNode.tsx    | 19 -------------
 .../FileDownloadNode/FileDownloadNode.tsx     | 21 --------------
 .../editor/nodes/LoginNode/LoginNode.tsx      | 19 -------------
 .../nodes/NavigationNode/NavigationNode.tsx   | 23 ---------------
 .../editor/nodes/TaskNode/TaskNode.tsx        | 19 -------------
 10 files changed, 161 deletions(-)

diff --git a/skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx b/skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx
index be0e832d..aaf809c4 100644
--- a/skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx
+++ b/skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx
@@ -78,7 +78,6 @@ function createTaskRequestObject(
     proxy_location: formValues.proxyLocation ?? ProxyLocation.Residential,
     navigation_payload: transform(formValues.navigationPayload),
     extracted_information_schema: extractedInformationSchema,
-    totp_verification_url: transform(formValues.totpVerificationUrl),
     totp_identifier: transform(formValues.totpIdentifier),
     error_code_mapping: errorCodeMapping,
   };
@@ -556,32 +555,6 @@ function CreateNewTaskForm({ initialValues }: Props) {
                   )}
                 />
                 <Separator />
-                <FormField
-                  control={form.control}
-                  name="totpVerificationUrl"
-                  render={({ field }) => (
-                    <FormItem>
-                      <div className="flex gap-16">
-                        <FormLabel>
-                          <div className="w-72">
-                            <h1 className="text-lg">2FA Verification URL</h1>
-                            <h2 className="text-base text-slate-400"></h2>
-                          </div>
-                        </FormLabel>
-                        <div className="w-full">
-                          <FormControl>
-                            <Input
-                              {...field}
-                              placeholder="Provide your 2FA endpoint"
-                              value={field.value === null ? "" : field.value}
-                            />
-                          </FormControl>
-                          <FormMessage />
-                        </div>
-                      </div>
-                    </FormItem>
-                  )}
-                />
                 <FormField
                   control={form.control}
                   name="totpIdentifier"
diff --git a/skyvern-frontend/src/routes/tasks/create/CreateNewTaskFormPage.tsx b/skyvern-frontend/src/routes/tasks/create/CreateNewTaskFormPage.tsx
index 1a9d08df..cfb67099 100644
--- a/skyvern-frontend/src/routes/tasks/create/CreateNewTaskFormPage.tsx
+++ b/skyvern-frontend/src/routes/tasks/create/CreateNewTaskFormPage.tsx
@@ -59,7 +59,6 @@ function CreateNewTaskFormPage() {
             ),
             errorCodeMapping: null,
             totpIdentifier: null,
-            totpVerificationUrl: null,
             webhookCallbackUrl: null,
             proxyLocation: null,
           }}
@@ -127,8 +126,6 @@ function CreateNewTaskFormPage() {
               : JSON.stringify(navigationPayload, null, 2),
           maxStepsOverride,
           totpIdentifier: data.workflow_definition.blocks[0].totp_identifier,
-          totpVerificationUrl:
-            data.workflow_definition.blocks[0].totp_verification_url,
           errorCodeMapping: JSON.stringify(errorCodeMapping, null, 2),
         }}
       />
diff --git a/skyvern-frontend/src/routes/tasks/create/SavedTaskForm.tsx b/skyvern-frontend/src/routes/tasks/create/SavedTaskForm.tsx
index 63fdedaa..05fc8220 100644
--- a/skyvern-frontend/src/routes/tasks/create/SavedTaskForm.tsx
+++ b/skyvern-frontend/src/routes/tasks/create/SavedTaskForm.tsx
@@ -54,7 +54,6 @@ function createTaskRequestObject(formValues: SavedTaskFormValues) {
     extracted_information_schema: safeParseMaybeJSONString(
       formValues.extractedInformationSchema,
     ),
-    totp_verification_url: transform(formValues.totpVerificationUrl),
     totp_identifier: transform(formValues.totpIdentifier),
     error_code_mapping: safeParseMaybeJSONString(formValues.errorCodeMapping),
   };
@@ -98,7 +97,6 @@ function createTaskTemplateRequestObject(values: SavedTaskFormValues) {
             values.extractedInformationSchema,
           ),
           max_steps_per_run: values.maxStepsOverride,
-          totp_verification_url: values.totpVerificationUrl,
           totp_identifier: values.totpIdentifier,
           error_code_mapping: safeParseMaybeJSONString(values.errorCodeMapping),
         },
@@ -705,32 +703,6 @@ function SavedTaskForm({ initialValues }: Props) {
                   )}
                 />
                 <Separator />
-                <FormField
-                  control={form.control}
-                  name="totpVerificationUrl"
-                  render={({ field }) => (
-                    <FormItem>
-                      <div className="flex gap-16">
-                        <FormLabel>
-                          <div className="w-72">
-                            <h1 className="text-lg">2FA Verification URL</h1>
-                            <h2 className="text-base text-slate-400"></h2>
-                          </div>
-                        </FormLabel>
-                        <div className="w-full">
-                          <FormControl>
-                            <Input
-                              {...field}
-                              placeholder="Provide your 2FA endpoint"
-                              value={field.value === null ? "" : field.value}
-                            />
-                          </FormControl>
-                          <FormMessage />
-                        </div>
-                      </div>
-                    </FormItem>
-                  )}
-                />
                 <FormField
                   control={form.control}
                   name="totpIdentifier"
diff --git a/skyvern-frontend/src/routes/tasks/create/retry/RetryTask.tsx b/skyvern-frontend/src/routes/tasks/create/retry/RetryTask.tsx
index 0b5d0a57..3a2ad368 100644
--- a/skyvern-frontend/src/routes/tasks/create/retry/RetryTask.tsx
+++ b/skyvern-frontend/src/routes/tasks/create/retry/RetryTask.tsx
@@ -38,7 +38,6 @@ function RetryTask() {
                 ),
           webhookCallbackUrl: task.request.webhook_callback_url ?? null,
           totpIdentifier: task.request.totp_identifier ?? null,
-          totpVerificationUrl: task.request.totp_verification_url ?? null,
           errorCodeMapping: task.request.error_code_mapping
             ? JSON.stringify(task.request.error_code_mapping, null, 2)
             : "",
diff --git a/skyvern-frontend/src/routes/tasks/create/taskFormTypes.ts b/skyvern-frontend/src/routes/tasks/create/taskFormTypes.ts
index 042ec93b..a9a4262a 100644
--- a/skyvern-frontend/src/routes/tasks/create/taskFormTypes.ts
+++ b/skyvern-frontend/src/routes/tasks/create/taskFormTypes.ts
@@ -11,7 +11,6 @@ const createNewTaskFormSchemaBase = z.object({
   navigationPayload: z.string().or(z.null()),
   extractedInformationSchema: z.string().or(z.null()),
   maxStepsOverride: z.number().or(z.null()).optional(),
-  totpVerificationUrl: z.string().or(z.null()),
   totpIdentifier: z.string().or(z.null()),
   errorCodeMapping: z.string().or(z.null()),
   proxyLocation: z.nativeEnum(ProxyLocation).or(z.null()),
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/ActionNode/ActionNode.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/ActionNode/ActionNode.tsx
index 7d012a36..b63dadfd 100644
--- a/skyvern-frontend/src/routes/workflows/editor/nodes/ActionNode/ActionNode.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/ActionNode/ActionNode.tsx
@@ -339,25 +339,6 @@ function ActionNode({ id, data }: NodeProps<ActionNode>) {
                   />
                 </div>
                 <Separator />
-                <div className="space-y-2">
-                  <div className="flex gap-2">
-                    <Label className="text-xs text-slate-300">
-                      2FA Verification URL
-                    </Label>
-                    <HelpTooltip
-                      content={helpTooltips["action"]["totpVerificationUrl"]}
-                    />
-                  </div>
-                  <WorkflowBlockInputTextarea
-                    nodeId={id}
-                    onChange={(value) => {
-                      handleChange("totpVerificationUrl", value);
-                    }}
-                    value={inputs.totpVerificationUrl ?? ""}
-                    placeholder={placeholders["action"]["totpVerificationUrl"]}
-                    className="nopan text-xs"
-                  />
-                </div>
                 <div className="space-y-2">
                   <div className="flex gap-2">
                     <Label className="text-xs text-slate-300">
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/FileDownloadNode/FileDownloadNode.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/FileDownloadNode/FileDownloadNode.tsx
index 6c668462..895103d0 100644
--- a/skyvern-frontend/src/routes/workflows/editor/nodes/FileDownloadNode/FileDownloadNode.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/FileDownloadNode/FileDownloadNode.tsx
@@ -317,27 +317,6 @@ function FileDownloadNode({ id, data }: NodeProps<FileDownloadNode>) {
                   />
                 </div>
                 <Separator />
-                <div className="space-y-2">
-                  <div className="flex gap-2">
-                    <Label className="text-xs text-slate-300">
-                      2FA Verification URL
-                    </Label>
-                    <HelpTooltip
-                      content={helpTooltips["download"]["totpVerificationUrl"]}
-                    />
-                  </div>
-                  <WorkflowBlockInputTextarea
-                    nodeId={id}
-                    onChange={(value) => {
-                      handleChange("totpVerificationUrl", value);
-                    }}
-                    value={inputs.totpVerificationUrl ?? ""}
-                    placeholder={
-                      placeholders["download"]["totpVerificationUrl"]
-                    }
-                    className="nopan text-xs"
-                  />
-                </div>
                 <div className="space-y-2">
                   <div className="flex gap-2">
                     <Label className="text-xs text-slate-300">
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/LoginNode/LoginNode.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/LoginNode/LoginNode.tsx
index 98f94f97..838f1757 100644
--- a/skyvern-frontend/src/routes/workflows/editor/nodes/LoginNode/LoginNode.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/LoginNode/LoginNode.tsx
@@ -331,25 +331,6 @@ function LoginNode({ id, data }: NodeProps<LoginNode>) {
                   </div>
                 </div>
                 <Separator />
-                <div className="space-y-2">
-                  <div className="flex gap-2">
-                    <Label className="text-xs text-slate-300">
-                      2FA Verification URL
-                    </Label>
-                    <HelpTooltip
-                      content={helpTooltips["login"]["totpVerificationUrl"]}
-                    />
-                  </div>
-                  <WorkflowBlockInputTextarea
-                    nodeId={id}
-                    onChange={(value) => {
-                      handleChange("totpVerificationUrl", value);
-                    }}
-                    value={inputs.totpVerificationUrl ?? ""}
-                    placeholder={placeholders["login"]["totpVerificationUrl"]}
-                    className="nopan text-xs"
-                  />
-                </div>
                 <div className="space-y-2">
                   <div className="flex gap-2">
                     <Label className="text-xs text-slate-300">
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/NavigationNode/NavigationNode.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/NavigationNode/NavigationNode.tsx
index 9ef7f2c3..3646219c 100644
--- a/skyvern-frontend/src/routes/workflows/editor/nodes/NavigationNode/NavigationNode.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/NavigationNode/NavigationNode.tsx
@@ -358,29 +358,6 @@ function NavigationNode({ id, data }: NodeProps<NavigationNode>) {
                   />
                 </div>
                 <Separator />
-                <div className="space-y-2">
-                  <div className="flex gap-2">
-                    <Label className="text-xs text-slate-300">
-                      2FA Verification URL
-                    </Label>
-                    <HelpTooltip
-                      content={
-                        helpTooltips["navigation"]["totpVerificationUrl"]
-                      }
-                    />
-                  </div>
-                  <WorkflowBlockInputTextarea
-                    nodeId={id}
-                    onChange={(value) => {
-                      handleChange("totpVerificationUrl", value);
-                    }}
-                    value={inputs.totpVerificationUrl ?? ""}
-                    placeholder={
-                      placeholders["navigation"]["totpVerificationUrl"]
-                    }
-                    className="nopan text-xs"
-                  />
-                </div>
                 <div className="space-y-2">
                   <div className="flex gap-2">
                     <Label className="text-xs text-slate-300">
diff --git a/skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNode.tsx b/skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNode.tsx
index 72b2bf4c..70da4793 100644
--- a/skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNode.tsx
+++ b/skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNode.tsx
@@ -387,25 +387,6 @@ function TaskNode({ id, data }: NodeProps<TaskNode>) {
                   />
                 </div>
                 <Separator />
-                <div className="space-y-2">
-                  <div className="flex gap-2">
-                    <Label className="text-xs text-slate-300">
-                      2FA Verification URL
-                    </Label>
-                    <HelpTooltip
-                      content={helpTooltips["task"]["totpVerificationUrl"]}
-                    />
-                  </div>
-                  <WorkflowBlockInputTextarea
-                    nodeId={id}
-                    onChange={(value) => {
-                      handleChange("totpVerificationUrl", value);
-                    }}
-                    value={inputs.totpVerificationUrl ?? ""}
-                    placeholder={placeholders["task"]["totpVerificationUrl"]}
-                    className="nopan text-xs"
-                  />
-                </div>
                 <div className="space-y-2">
                   <div className="flex gap-2">
                     <Label className="text-xs text-slate-300">