vodorod/Dorod-Sky
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

handle navigation failure and fail a task in workflow run (#1205)

Browse Source
This commit is contained in:
Shuchang Zheng
2024-11-15 20:07:01 -08:00
committed by GitHub
parent 9273f698ba
commit 19fcd4065f
1 changed files with 30 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
skyvern/forge/sdk/workflow/models/block.py
View File

@@ -298,14 +298,37 @@ class TaskBlock(Block):
raise Exception(f"Organization is missing organization_id={workflow.organization_id}") raise Exception(f"Organization is missing organization_id={workflow.organization_id}")
browser_state: BrowserState | None = None browser_state: BrowserState | None = None
if is_first_task: try:
browser_state = await app.BROWSER_MANAGER.get_or_create_for_workflow_run( if is_first_task:
workflow_run=workflow_run, url=self.url browser_state = await app.BROWSER_MANAGER.get_or_create_for_workflow_run(
workflow_run=workflow_run, url=self.url
)
else:
browser_state = app.BROWSER_MANAGER.get_for_workflow_run(workflow_run_id=workflow_run_id)
if browser_state is None:
raise MissingBrowserState(task_id=task.task_id, workflow_run_id=workflow_run_id)
except FailedToNavigateToUrl as e:
# Make sure the task is marked as failed in the database before raising the exception
await app.DATABASE.update_task(
task.task_id,
status=TaskStatus.failed,
organization_id=workflow.organization_id,
failure_reason=str(e),
) )
else: raise e
browser_state = app.BROWSER_MANAGER.get_for_workflow_run(workflow_run_id=workflow_run_id) except Exception as e:
if browser_state is None: await app.DATABASE.update_task(
raise MissingBrowserState(task_id=task.task_id, workflow_run_id=workflow_run_id) task.task_id,
status=TaskStatus.failed,
organization_id=workflow.organization_id,
failure_reason=str(e),
)
LOG.exception(
"Failed to get browser state for task",
task_id=task.task_id,
workflow_run_id=workflow_run_id,
)
raise e
working_page = await browser_state.get_working_page() working_page = await browser_state.get_working_page()
if not working_page: if not working_page: