vodorod/Dorod-Sky
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Validate json and don't allow null parameter values when running workflow (#866)

Browse Source
This commit is contained in:
Kerem Yilmaz
2024-09-20 05:23:20 -07:00
committed by GitHub
parent e9184bc399
commit 0beb929cf3
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx
View File

@@ -1,5 +1,4 @@
import { getClient } from "@/api/AxiosClient"; import { getClient } from "@/api/AxiosClient";
import { WorkflowParameter } from "@/api/types";
import { Form, FormControl, FormField, FormItem } from "@/components/ui/form"; import { Form, FormControl, FormField, FormItem } from "@/components/ui/form";
import { useCredentialGetter } from "@/hooks/useCredentialGetter"; import { useCredentialGetter } from "@/hooks/useCredentialGetter";
import { useMutation, useQueryClient } from "@tanstack/react-query"; import { useMutation, useQueryClient } from "@tanstack/react-query";
@@ -22,6 +21,7 @@ import fetchToCurl from "fetch-to-curl";
import { apiBaseUrl } from "@/util/env"; import { apiBaseUrl } from "@/util/env";
import { useApiCredential } from "@/hooks/useApiCredential"; import { useApiCredential } from "@/hooks/useApiCredential";
import { copyText } from "@/util/copyText"; import { copyText } from "@/util/copyText";
import { WorkflowParameter } from "./types/workflowTypes";
type Props = { type Props = {
workflowParameters: Array<WorkflowParameter>; workflowParameters: Array<WorkflowParameter>;
@@ -152,6 +152,9 @@ function RunWorkflowForm({ workflowParameters, initialValues }: Props) {
return "Invalid JSON"; return "Invalid JSON";
} }
} }
if (value === null) {
return "This field is required";
}
}, },
}} }}
render={({ field }) => { render={({ field }) => {

5
skyvern-frontend/src/routes/workflows/WorkflowRunParameters.tsx
View File

@@ -1,9 +1,12 @@
import { getClient } from "@/api/AxiosClient"; import { getClient } from "@/api/AxiosClient";
import { WorkflowApiResponse, WorkflowParameterValueType } from "@/api/types";
import { useCredentialGetter } from "@/hooks/useCredentialGetter"; import { useCredentialGetter } from "@/hooks/useCredentialGetter";
import { useQuery } from "@tanstack/react-query"; import { useQuery } from "@tanstack/react-query";
import { useLocation, useParams } from "react-router-dom"; import { useLocation, useParams } from "react-router-dom";
import { RunWorkflowForm } from "./RunWorkflowForm"; import { RunWorkflowForm } from "./RunWorkflowForm";
import {
WorkflowApiResponse,
WorkflowParameterValueType,
} from "./types/workflowTypes";
function defaultValue(type: WorkflowParameterValueType) { function defaultValue(type: WorkflowParameterValueType) {
switch (type) { switch (type) {